This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Migrate to Askama 0.14 + Dependency Updates & Auth Refactor#1
Open
uggla wants to merge 10 commits intoNeo-Ciber94:mainfrom
Open
Migrate to Askama 0.14 + Dependency Updates & Auth Refactor#1uggla wants to merge 10 commits intoNeo-Ciber94:mainfrom
uggla wants to merge 10 commits intoNeo-Ciber94:mainfrom
Conversation
- Bumped askama to 0.14.0 and removed askama_axum, as it's no longer needed. - Updated axum and axum-extra to latest compatible versions. - Refactored all IntoResponse impls to use axum's version directly. - Rewrote OAuth client setup for discord, github, and google auth routes to match new oauth2 5.0 API. - Replaced async_http_client with reqwest client for token exchange, avoiding deprecated pattern. - Cleaned up imports and removed now-unused deps like askama_escape and humansize. - Bumped edition to 2024. - Fixed the logic for `auth_middleware`: `Option<CurrentUser>` can no longer be used as middleware input. - Add a proxy route to load images from Google.
- Remove serde_json and tower, not needed. - Bump: - anyhow "1.0.98" to "1.0.99" - chrono "0.4.31" to "0.4.41" - cookie "0.18.0" to "0.18.1" - reqwest "0.12.22" to "0.12.23" - tokio "1.34.0" to "1.47.1" - uuid "1.17.0" to "1.18.0"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to Askama 0.14 + Dependency Updates & Auth Refactor
This PR performs a full upgrade of the template rendering stack by migrating from
askama 0.12toaskama 0.14, along with a set of other important dependency updates. Key changes include:🔧 Major Changes
Askama 0.14 migration:
askama_axum, which is no longer necessary.IntoResponseimplementations were updated to useaxumdirectly..render().unwrap().into_response()in places whereaskama_axumwas previously used.OAuth logic refactor:
oauth2tov5.0.0, which brings a new API.BasicClientbuilder style.async_http_clientwith a customreqwestclient (with redirects disabled for safety).Middleware fixes:
Option<CurrentUser>is no longer usable in middleware due to trait constraints in the updated axum version.auth_middlewarelogic accordingly.Add image proxy route:
📦 Dependency Updates
askama→ 0.14axum→ 0.8.4axum-extra→ 0.10.1oauth2→ 5.0.0reqwest→ 0.12.22sqlx→ 0.8.6tower,tower-http,uuid,tracing,tracing-subscriber,serde,serde_json,anyhow– all bumped to latest versions🧹 Cleanup
askama_axum,askama_escape,humansize, etc.2024.Let me know if you'd like to split this PR further or squash the commits before merge.