Skip to content

Conversation

k4k7us23
Copy link
Contributor

@k4k7us23 k4k7us23 commented Jul 2, 2025

Changes description

  • This PR fixes code coverage report generation, when ui tests are running under Test Orchestrator
  • The issue is fixed both for connected devices and for gradle managed devices
  • Due to the fix, configuration "connected-device-clear-package-data.yaml" was unignored
  • A new test configuration for gradle managed devices under Test Orchestrator was added (gradle-managed-device-clear-package-data.yaml)

Fix explanation

  • It turns out, that when tests are executed under Test Orchestrator, each test will produce it's own "*.ec" file with specific name. Please, see the screenshoot below, for better understanding
  • orchestrator
  • That is why, I have added generic build folder patterns to getExecutionDataFileTree() function

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.06%. Comparing base (dc9f71c) to head (544906c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #118   +/-   ##
=========================================
  Coverage     86.06%   86.06%           
  Complexity       59       59           
=========================================
  Files             8        8           
  Lines           244      244           
  Branches         21       21           
=========================================
  Hits            210      210           
  Misses           13       13           
  Partials         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Rolf-Smit Rolf-Smit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being very late to review this. I have some small comments, but in general I think this looks good.

Thanks for jumping in and helping out with this project, really appreciated.

@k4k7us23 k4k7us23 force-pushed the fix/orchestrator_test_execution branch from f1f4870 to 544906c Compare July 23, 2025 11:46
@k4k7us23 k4k7us23 requested a review from Rolf-Smit July 23, 2025 11:55
@Rolf-Smit Rolf-Smit merged commit b61f4e9 into NeoTech-Software:master Jul 23, 2025
3 checks passed
@Rolf-Smit
Copy link
Contributor

@k4k7us23 again thanks for your help resolving this issue, greatly appreciated. I will soon create a release with this fix in it.

Rolf-Smit added a commit that referenced this pull request Jul 24, 2025
- Fixed: Coverage not reported correctly when running connected tests using testOrchestrator (#118)
- Based on Android Gradle Plugin 8.11 API
- Compatible with Gradle version 8.13+
@Rolf-Smit Rolf-Smit mentioned this pull request Jul 24, 2025
Rolf-Smit added a commit that referenced this pull request Jul 25, 2025
- Fixed: Coverage not reported correctly when running connected tests using testOrchestrator (#118)
- Based on Android Gradle Plugin 8.11 API
- Compatible with Gradle version 8.13+
@Rolf-Smit
Copy link
Contributor

@k4k7us23 just letting you know that this is now available in release 1.11.0, small heads up though, this release is based on the most recent stable Android Gradle Plugin release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants