feat : Implement Hasher trait for Tip5

[elielnfinic]

This PR fixes #207

[jan-ferdinand]

Thanks for taking this on! Right now, there are some problems with the implementation. They should be relatively easy to resolve, though. 🙂

[jan-ferdinand]

Note also that we're using conventional commits for our git commit messages. Before merging this PR, I'd like you to squash the commits and use a message like “feat(Tip5): Implement the Hasher trait”. Feel free to change the message if you like. 👍

[elielnfinic]

Thanks @jan-ferdinand for your review and suggestions. I hope I was able to resolve your review messages. Please check out this new commit.

[jan-ferdinand]

Cool, this is coming together nicely. I've left a few nits inline. Since I have crammed a bunch of comments into a rather tight space, here's what I re-wrote the second loop to on my end. Feel free to pick whetever you like, there's no obligation to take any of it.

for chunk in bfield_elements.chunks(Tip5::RATE).into_iter() {
    let mut buffer = [BFieldElement::ZERO; Tip5::RATE];
    for (buffer_elem, chunk_elem) in buffer.iter_mut().zip(chunk) {
        *buffer_elem = chunk_elem;
    }
    self.absorb(buffer)
}

Lastly, the commit message looks good now. 👌 Can I ask you to also change the commit's description? “Adding test” and “Renaming test” don't really describe what's going on. 😉 You can also leave it empty if you want; I think the description by itself can be sufficient. Your choice. 🙂

[elielnfinic]

I like this suggestion. Thank you.

[coveralls]

coverage: 97.811% (-0.01%) from 97.822%
when pulling 94bdc3a on elielnfinic:feat/hasher-for-tip5
into 2dba318 on Neptune-Crypto:master.

[jan-ferdinand]

This is looking great now! ⭐

The only remaining nit I have is the commit's description (the message is great). You can change the description in a number of ways, for example

git commit --amend -m "feat(Tip5) : Implement the Hasher trait" -m "new description"

or using an interactive rebase with the “reword” option.

[elielnfinic]

My bad, I believe I had to clean that description the rebase msg file.
Just amended the commit.

Thank you.

[jan-ferdinand]

Thanks for your contribution! 🎉