i18n: Update Channel settings and User Notice strings#603
i18n: Update Channel settings and User Notice strings#603SupertigerDev merged 1 commit intoNerimity:mainfrom
Conversation
📝 WalkthroughWalkthroughThis pull request replaces hard-coded UI text with translation keys across multiple components and locale files. Changes include updating references in ServerSettingsChannel.tsx, AccountSettings.tsx, and adding corresponding translation entries in en-gb.json for channel settings, webhooks, and account notice labels. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/settings/AccountSettings.tsx (1)
703-759: Rename this block to match the new “User Notice” terminology.The UI now consistently says
User Notice, but this component and its local state still useChannelNotice. Renaming the component/signal names here would make future i18n and code search much less confusing.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/settings/AccountSettings.tsx` around lines 703 - 759, Rename the component and its local state to use "User Notice" terminology: change the function name ChannelNoticeBlock to UserNoticeBlock, rename signals/variables setChannelNotice and channelNotice to setUserNotice and userNotice (and update usages in defaultInput, onMount, save, deleteNotice), and update the RawChannelNotice type name to RawUserNotice (or map to the new type name if it already exists); also adjust any references to getDMChannelNotice, updateDMChannelNotice, and deleteDMChannelNotice calls/parameters in this file if the API surface has been renamed to user-notice equivalents, otherwise leave the API calls but ensure local identifiers reflect "UserNotice".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/components/settings/AccountSettings.tsx`:
- Around line 703-759: Rename the component and its local state to use "User
Notice" terminology: change the function name ChannelNoticeBlock to
UserNoticeBlock, rename signals/variables setChannelNotice and channelNotice to
setUserNotice and userNotice (and update usages in defaultInput, onMount, save,
deleteNotice), and update the RawChannelNotice type name to RawUserNotice (or
map to the new type name if it already exists); also adjust any references to
getDMChannelNotice, updateDMChannelNotice, and deleteDMChannelNotice
calls/parameters in this file if the API surface has been renamed to user-notice
equivalents, otherwise leave the API calls but ensure local identifiers reflect
"UserNotice".
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7786d2ad-b57c-459c-9808-46dda92192f2
📒 Files selected for processing (3)
src/components/servers/settings/channel/ServerSettingsChannel.tsxsrc/components/settings/AccountSettings.tsxsrc/locales/list/en-gb.json
What does this PR do?
Screenshots
Did you test your code?
Yes
Checklist
Summary by CodeRabbit
Release Notes