Skip to content

i18n: Update Channel settings and User Notice strings#603

Merged
SupertigerDev merged 1 commit intoNerimity:mainfrom
1enify:i18n-1
Mar 6, 2026
Merged

i18n: Update Channel settings and User Notice strings#603
SupertigerDev merged 1 commit intoNerimity:mainfrom
1enify:i18n-1

Conversation

@1enify
Copy link
Copy Markdown
Contributor

@1enify 1enify commented Mar 6, 2026

What does this PR do?

  • Updates Account settings to say "User Notice"
  • Adds a separate string for Slow Mode in channel settings
  • Translates Webhooks in Channel settings

Screenshots

Здымак экрана ад 2026-03-06 23-42-11 Здымак экрана ад 2026-03-06 23-43-18

Did you test your code?

Yes

Checklist

  • Changes are clear, concise, and easy to review
  • Code has been tested and works as intended
  • Text/content changes support internationalization (i18n)
  • Any new user-facing strings are properly localized

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated localization strings for channel settings, including slow mode and channel notice labels.
    • Corrected account settings localization terminology for user notices.
    • Added localization support for webhook button labels.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 6, 2026

📝 Walkthrough

Walkthrough

This pull request replaces hard-coded UI text with translation keys across multiple components and locale files. Changes include updating references in ServerSettingsChannel.tsx, AccountSettings.tsx, and adding corresponding translation entries in en-gb.json for channel settings, webhooks, and account notice labels.

Changes

Cohort / File(s) Summary
Component Localization
src/components/servers/settings/channel/ServerSettingsChannel.tsx, src/components/settings/AccountSettings.tsx
Replaced hard-coded UI strings with i18n translation keys. ServerSettingsChannel now uses servers.settings.channel.* and servers.settings.webhook.* keys. AccountSettings replaced channelNotice-related keys with userNotice variants for account-specific text.
Locale Data
src/locales/list/en-gb.json
Added new translation keys under servers.settings.channel (slowMode, channelNotice, channelNoticeDescription, channelNoticeTooLong) and servers.settings.webhook (addButton). Replaced settings.account channelNotice entries with userNotice equivalents.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

Poem

🐰✨ Strings once hardened now take flight,
With i18n keys shining bright!
From channelNotice to userNotice we hop,
Translation magic—it won't stop!
Every language, every tongue,
Now speaks true, clear, and young! 🌍

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main changes: updating i18n strings for channel settings and user notice labels.
Description check ✅ Passed The description covers all required template sections with concrete details: explains what the PR does, includes screenshots, confirms testing, and checks all checklist items.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/components/settings/AccountSettings.tsx (1)

703-759: Rename this block to match the new “User Notice” terminology.

The UI now consistently says User Notice, but this component and its local state still use ChannelNotice. Renaming the component/signal names here would make future i18n and code search much less confusing.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/components/settings/AccountSettings.tsx` around lines 703 - 759, Rename
the component and its local state to use "User Notice" terminology: change the
function name ChannelNoticeBlock to UserNoticeBlock, rename signals/variables
setChannelNotice and channelNotice to setUserNotice and userNotice (and update
usages in defaultInput, onMount, save, deleteNotice), and update the
RawChannelNotice type name to RawUserNotice (or map to the new type name if it
already exists); also adjust any references to getDMChannelNotice,
updateDMChannelNotice, and deleteDMChannelNotice calls/parameters in this file
if the API surface has been renamed to user-notice equivalents, otherwise leave
the API calls but ensure local identifiers reflect "UserNotice".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/components/settings/AccountSettings.tsx`:
- Around line 703-759: Rename the component and its local state to use "User
Notice" terminology: change the function name ChannelNoticeBlock to
UserNoticeBlock, rename signals/variables setChannelNotice and channelNotice to
setUserNotice and userNotice (and update usages in defaultInput, onMount, save,
deleteNotice), and update the RawChannelNotice type name to RawUserNotice (or
map to the new type name if it already exists); also adjust any references to
getDMChannelNotice, updateDMChannelNotice, and deleteDMChannelNotice
calls/parameters in this file if the API surface has been renamed to user-notice
equivalents, otherwise leave the API calls but ensure local identifiers reflect
"UserNotice".

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7786d2ad-b57c-459c-9808-46dda92192f2

📥 Commits

Reviewing files that changed from the base of the PR and between 5b3ae3e and f5f8d38.

📒 Files selected for processing (3)
  • src/components/servers/settings/channel/ServerSettingsChannel.tsx
  • src/components/settings/AccountSettings.tsx
  • src/locales/list/en-gb.json

@SupertigerDev SupertigerDev merged commit 14c0d5a into Nerimity:main Mar 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants