Skip to content

Translate Badge Inventory#613

Merged
SupertigerDev merged 1 commit intoNerimity:mainfrom
1enify:i18n-1
Mar 17, 2026
Merged

Translate Badge Inventory#613
SupertigerDev merged 1 commit intoNerimity:mainfrom
1enify:i18n-1

Conversation

@1enify
Copy link
Copy Markdown
Contributor

@1enify 1enify commented Mar 14, 2026

What does this PR do?

  • Translated owned badges

Screenshots

image

Did you test your code?

Yes

Checklist

  • Changes are clear, concise, and easy to review
  • Code has been tested and works as intended
  • Text/content changes support internationalization (i18n)
  • Any new user-facing strings are properly localized

Summary by CodeRabbit

  • Localization
    • Added translation support for badge settings, including error messages, acquisition notices, and inventory labels.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e7339473-4ad3-4b65-9525-419ecf467731

📥 Commits

Reviewing files that changed from the base of the PR and between 0b70e6e and 3f7f9fb.

📒 Files selected for processing (2)
  • src/components/settings/BadgeSettings.tsx
  • src/locales/list/en-gb.json

📝 Walkthrough

Walkthrough

Hardcoded UI strings in badge settings are replaced with i18n translation function calls, and corresponding translation keys are added to the English (GB) locale file to support internationalization of error messages, notices, and badge inventory labels.

Changes

Cohort / File(s) Summary
Badge Settings Localization
src/components/settings/BadgeSettings.tsx
Replaced 4 hardcoded strings with i18n calls: unremovable badge error (title/body), acquisition notice, owned badges label, and badge acquisition date descriptors.
En-GB Locale Strings
src/locales/list/en-gb.json
Added 5 new translation keys under badges: acquisitionNotice, unremovableError (title/body), and inventory (ownedBadges/acquireDate with placeholders).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Strings hop into the i18n nest,
Where badges find their locale vest,
No more hardcoded, wild and free—
Translation keys in harmony! 🌍✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Translate Badge Inventory' directly aligns with the main objective of the PR, which is to add internationalization (i18n) translations for the badge inventory feature in BadgeSettings.tsx and en-gb.json.
Description check ✅ Passed The description follows the template structure with most sections completed: objectives are clear, screenshots are provided, testing confirmation included, and all checklist items are marked as done. However, 'Additional context' section is missing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

@SupertigerDev SupertigerDev merged commit 04243c3 into Nerimity:main Mar 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants