Remove Palestine checkbox from Profile settings#620
Remove Palestine checkbox from Profile settings#6201enify wants to merge 1 commit intoNerimity:mainfrom
Conversation
📝 WalkthroughWalkthroughThis PR removes the in-page Palestine border UI toggle from profile settings, deletes its associated translation key, and updates the Palestine badge description to a fixed message rather than referencing profile settings configuration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/locales/list/en-gb.json`:
- Line 642: The locale key "palestineDescription" was updated in en-gb.json but
the same key remains outdated in other locale files; update the
"palestineDescription" entry in each of the listed locale files (uk.json,
tr-tr.json, sv-sv.json, ru-ru.json, pt-br.json, nl-nl.json, pl-pl.json, it.json,
fil-ph.json, fr-FR.json, de-de.json, es-es.json, be-tarask.json) to an accurate
translation of "Free Palestine🇵🇸" (or the agreed localized phrase) so all
files contain the same key "palestineDescription" with the correct translated
value. Ensure you preserve JSON formatting and escaping, run a quick
lint/validation of locales, and commit the updated files.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5aa795c6-405a-4eab-9364-de179c9894bd
📒 Files selected for processing (2)
src/components/settings/ProfileSettings.tsxsrc/locales/list/en-gb.json
💤 Files with no reviewable changes (1)
- src/components/settings/ProfileSettings.tsx
| "noticeTitle": "Donations", | ||
| "notice": "Support this project by donating money.", | ||
| "palestineDescription": "Can be equipped by going to profile settings", | ||
| "palestineDescription": "Free Palestine🇵🇸", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check if other locale files contain the palestineDescription key and its current value
rg -n "palestineDescription" src/locales/list/Repository: Nerimity/nerimity-web
Length of output: 1715
Update all locale files with the new palestineDescription text.
The en-gb.json change is correct, but 13 other locale files still contain the outdated description referencing the removed profile settings toggle:
- uk.json, tr-tr.json, sv-sv.json, ru-ru.json, pt-br.json, nl-nl.json, pl-pl.json, it.json, fil-ph.json, fr-FR.json, de-de.json, es-es.json, be-tarask.json
Each needs to be updated with an appropriate translation of "Free Palestine🇵🇸" to maintain consistency across all supported languages.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/locales/list/en-gb.json` at line 642, The locale key
"palestineDescription" was updated in en-gb.json but the same key remains
outdated in other locale files; update the "palestineDescription" entry in each
of the listed locale files (uk.json, tr-tr.json, sv-sv.json, ru-ru.json,
pt-br.json, nl-nl.json, pl-pl.json, it.json, fil-ph.json, fr-FR.json,
de-de.json, es-es.json, be-tarask.json) to an accurate translation of "Free
Palestine🇵🇸" (or the agreed localized phrase) so all files contain the same
key "palestineDescription" with the correct translated value. Ensure you
preserve JSON formatting and escaping, run a quick lint/validation of locales,
and commit the updated files.
What does this PR do?
Screenshots
Did you test your code?
Yes
Additional context
The badge description (screenshot 2) is just a placeholder, feel free to change.
Checklist
Summary by CodeRabbit
Bug Fixes
Documentation