Skip to content

Remove Palestine checkbox from Profile settings#620

Open
1enify wants to merge 1 commit intoNerimity:mainfrom
1enify:main
Open

Remove Palestine checkbox from Profile settings#620
1enify wants to merge 1 commit intoNerimity:mainfrom
1enify:main

Conversation

@1enify
Copy link
Copy Markdown
Contributor

@1enify 1enify commented Mar 25, 2026

What does this PR do?

  • Removes checkbox for Palestine badge from Profile settings

Screenshots

image image

Did you test your code?

Yes

Additional context

The badge description (screenshot 2) is just a placeholder, feel free to change.

Checklist

  • Changes are clear, concise, and easy to review
  • Code has been tested and works as intended
  • Text/content changes support internationalization (i18n)
  • Any new user-facing strings are properly localized

Summary by CodeRabbit

  • Bug Fixes

    • Removed the Palestine border avatar customization feature from profile settings. Users will no longer have the option to apply a Palestine border effect to their avatars through the profile settings interface.
  • Documentation

    • Updated the Palestine badge description text in application translations with new messaging to better communicate the badge's purpose.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026

📝 Walkthrough

Walkthrough

This PR removes the in-page Palestine border UI toggle from profile settings, deletes its associated translation key, and updates the Palestine badge description to a fixed message rather than referencing profile settings configuration.

Changes

Cohort / File(s) Summary
Component UI Removal
src/components/settings/ProfileSettings.tsx
Removed the PalestineBorder component block and associated imports (toggleBadge, Checkbox, hasBit, USER_BADGES) that enabled badge toggling via profile settings.
Localization Updates
src/locales/list/en-gb.json
Removed palestineBorder translation key from account.profile section; updated palestineDescription in account.badges from generic text to fixed message "Free Palestine🇵🇸".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 A border once toggled, now set in stone,
The settings grew lighter, a profile slimmed down,
One message remains, steadfast and alone,
Free Palestine echoes, through text and through town! 🇵🇸

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing the Palestine checkbox from Profile settings, which matches the actual code removal in ProfileSettings.tsx.
Description check ✅ Passed The PR description follows the template with all required sections completed: 'What does this PR do', screenshots, testing confirmation, additional context, and a fully checked checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/locales/list/en-gb.json`:
- Line 642: The locale key "palestineDescription" was updated in en-gb.json but
the same key remains outdated in other locale files; update the
"palestineDescription" entry in each of the listed locale files (uk.json,
tr-tr.json, sv-sv.json, ru-ru.json, pt-br.json, nl-nl.json, pl-pl.json, it.json,
fil-ph.json, fr-FR.json, de-de.json, es-es.json, be-tarask.json) to an accurate
translation of "Free Palestine🇵🇸" (or the agreed localized phrase) so all
files contain the same key "palestineDescription" with the correct translated
value. Ensure you preserve JSON formatting and escaping, run a quick
lint/validation of locales, and commit the updated files.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5aa795c6-405a-4eab-9364-de179c9894bd

📥 Commits

Reviewing files that changed from the base of the PR and between 196df4f and 265bdab.

📒 Files selected for processing (2)
  • src/components/settings/ProfileSettings.tsx
  • src/locales/list/en-gb.json
💤 Files with no reviewable changes (1)
  • src/components/settings/ProfileSettings.tsx

"noticeTitle": "Donations",
"notice": "Support this project by donating money.",
"palestineDescription": "Can be equipped by going to profile settings",
"palestineDescription": "Free Palestine🇵🇸",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check if other locale files contain the palestineDescription key and its current value

rg -n "palestineDescription" src/locales/list/

Repository: Nerimity/nerimity-web

Length of output: 1715


Update all locale files with the new palestineDescription text.

The en-gb.json change is correct, but 13 other locale files still contain the outdated description referencing the removed profile settings toggle:

  • uk.json, tr-tr.json, sv-sv.json, ru-ru.json, pt-br.json, nl-nl.json, pl-pl.json, it.json, fil-ph.json, fr-FR.json, de-de.json, es-es.json, be-tarask.json

Each needs to be updated with an appropriate translation of "Free Palestine🇵🇸" to maintain consistency across all supported languages.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/locales/list/en-gb.json` at line 642, The locale key
"palestineDescription" was updated in en-gb.json but the same key remains
outdated in other locale files; update the "palestineDescription" entry in each
of the listed locale files (uk.json, tr-tr.json, sv-sv.json, ru-ru.json,
pt-br.json, nl-nl.json, pl-pl.json, it.json, fil-ph.json, fr-FR.json,
de-de.json, es-es.json, be-tarask.json) to an accurate translation of "Free
Palestine🇵🇸" (or the agreed localized phrase) so all files contain the same
key "palestineDescription" with the correct translated value. Ensure you
preserve JSON formatting and escaping, run a quick lint/validation of locales,
and commit the updated files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant