Skip to content

Conversation

@Nerivec
Copy link
Owner

@Nerivec Nerivec commented Dec 11, 2025

  • move various "pickers" to react-select:
    • searchable
    • can multi-select as needed (cluster multi picker)
  • fix issues regarding custom clusters in dev console (logic / priority)

Closes #356

CC: @burmistrzak re Koenkk/zigbee-herdsman#1503 (comment)

@burmistrzak
Copy link

@Nerivec Tangentially related, but why do we name them input and output clusters?
Isn't the official terminology client and server clusters?

See ZCL spec 2.2.2 Client/Server Model for reference.

@Nerivec
Copy link
Owner Author

Nerivec commented Dec 11, 2025

Depends where you look, sometimes it's in/out (e.g. ZDO spec), sometimes it's server/client (e.g. ZCL spec)...

@burmistrzak
Copy link

@Nerivec Don't know about you, but I find client/server somehow more intuitive. Input/output always trips me up. 😅

@Nerivec Nerivec marked this pull request as ready for review December 13, 2025 14:22
@Nerivec Nerivec requested a review from Koenkk December 13, 2025 14:22
@Nerivec Nerivec merged commit e173f92 into main Dec 14, 2025
5 checks passed
@Nerivec Nerivec deleted the revamp-select branch December 14, 2025 00:45
@burmistrzak
Copy link

@Nerivec Happy New Year! Hope you had a good time. 😊

The new pickers are working good! Although, I noticed something: Cluster attributes are seemingly not in alphabetical order. Are they perhaps sorted by ID?

Also, do we have a "standard" for naming custom cluster/attributes? Some for example are prefixed with the manufacturer's name while others are not...

@Nerivec
Copy link
Owner Author

Nerivec commented Jan 1, 2026

The underlying data should already be sorted when sent by Z2M I believe (side-effect of deterministic stringify if I'm not mistaken).
Do you see this on a particular page/cluster?

For custom clusters, the naming often has prefixes from the old format in ZH, but new ones are determined mostly by whomever implemented them in ZHC... With on-site declarations in ZHC, there isn't as much of a need to de-conflict names, so could be without prefix... I'm not sure if Koenkk is enforcing a particular pattern in ZHC in new PRs.

@burmistrzak
Copy link

@Nerivec Sorry, have to correct myself here a bit. 😅

After checking a few other clusters, it looks like only hvacThermostat is affected. While the list of attributes is in alphabetical order, Sinope* and Stelpro* are the first few entries... 🤔

I think it would make sense to slightly separate default attributes from custom additions/overrides. Similar to how it's already done with the cluster picker.

For custom clusters, the naming often has prefixes from the old format in ZH, but new ones are determined mostly by whomever implemented them in ZHC... With on-site declarations in ZHC, there isn't as much of a need to de-conflict names, so could be without prefix... I'm not sure if Koenkk is enforcing a particular pattern in ZHC in new PRs.

@Koenkk Do we have guidelines for naming custom cluster attributes? With or without prefix?

@Nerivec
Copy link
Owner Author

Nerivec commented Jan 2, 2026

That would be the capital letters that sort first.
An overridden ZCL cluster does not make the difference between a custom attribute and a ZCL one, can't actually, since could very well override a ZCL attribute.

@burmistrzak
Copy link

@Nerivec Ah, I see. 👌

So it wouldn't be possible to sort the attribute picker in such a way that custom(ized) attributes are listed first and available default ZCL attributes appear in their own subsection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants