-
-
Notifications
You must be signed in to change notification settings - Fork 18
feat: revamp select #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: revamp select #363
Conversation
0e34afc to
7924ffa
Compare
|
@Nerivec Tangentially related, but why do we name them input and output clusters? See ZCL spec 2.2.2 Client/Server Model for reference. |
|
Depends where you look, sometimes it's in/out (e.g. ZDO spec), sometimes it's server/client (e.g. ZCL spec)... |
f9d0eeb to
52f5d5c
Compare
|
@Nerivec Don't know about you, but I find client/server somehow more intuitive. Input/output always trips me up. 😅 |
|
@Nerivec Happy New Year! Hope you had a good time. 😊 The new pickers are working good! Although, I noticed something: Cluster attributes are seemingly not in alphabetical order. Are they perhaps sorted by ID? Also, do we have a "standard" for naming custom cluster/attributes? Some for example are prefixed with the manufacturer's name while others are not... |
|
The underlying data should already be sorted when sent by Z2M I believe (side-effect of deterministic stringify if I'm not mistaken). For custom clusters, the naming often has prefixes from the old format in ZH, but new ones are determined mostly by whomever implemented them in ZHC... With on-site declarations in ZHC, there isn't as much of a need to de-conflict names, so could be without prefix... I'm not sure if Koenkk is enforcing a particular pattern in ZHC in new PRs. |
|
@Nerivec Sorry, have to correct myself here a bit. 😅 After checking a few other clusters, it looks like only I think it would make sense to slightly separate default attributes from custom additions/overrides. Similar to how it's already done with the cluster picker.
@Koenkk Do we have guidelines for naming custom cluster attributes? With or without prefix? |
|
That would be the capital letters that sort first. |
|
@Nerivec Ah, I see. 👌 So it wouldn't be possible to sort the attribute picker in such a way that custom(ized) attributes are listed first and available default ZCL attributes appear in their own subsection? |
Closes #356
CC: @burmistrzak re Koenkk/zigbee-herdsman#1503 (comment)