fix: improve list feature display #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-only and editable)
Nerivec
force-pushed
the
list-of-composite-display
branch
from
bd7992a to
4fd3fc6
Compare
Owner
|
I fixed some issues with the structure, and tried to simplify as much as possible. I had to make some mocks to test the display though (flipped access on |
Contributor
Author
|
Looks correct to me with the read only setup I have for the device. Thanks for the quick fixes! |
Nerivec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read-only and editable list-of-composite exposes (e.g. mmwave_targets) now render the same way as composite containing composites instead of raw JSON.
Visually:
