Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| else | ||
| { | ||
| backgroundColor = QColor("#404040"); | ||
| backgroundColor = QColor("#404040"); // test |
There was a problem hiding this comment.
warning: The QColor ctor taking RGB int value is cheaper than one taking string literals [clazy-qcolor-from-literal]
| backgroundColor = QColor("#404040"); // test | |
| backgroundColor = QColor(0x404040); // test |
| backgroundColor = QColor("#4A273D"); | ||
| } | ||
| { // o | ||
| backgroundColor = QColor("#4A273D"); // xd |
There was a problem hiding this comment.
warning: The QColor ctor taking RGB int value is cheaper than one taking string literals [clazy-qcolor-from-literal]
| backgroundColor = QColor("#4A273D"); // xd | |
| backgroundColor = QColor(0x4A273D); // xd |
| else | ||
| { | ||
| backgroundColor = QColor("#404040"); | ||
| backgroundColor = QColor("#404040"); // test |
There was a problem hiding this comment.
warning: The QColor ctor taking RGB int value is cheaper than one taking string literals [clazy-qcolor-from-literal]
| backgroundColor = QColor("#404040"); // test | |
| backgroundColor = QColor(0x404040); // test |
Co-authored-by: Mm2PL <mm2pl+gh@kotmisia.pl> Reviewed-by: Mm2PL <mm2pl+gh@kotmisia.pl>
…no#6619) Reviewed-by: nerix <nero.9@hotmail.de> Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
| }, | ||
| this->signalHolder_); | ||
|
|
||
| this->menu_.addAction( |
There was a problem hiding this comment.
warning: Pass a context object as 2nd addAction parameter [clazy-connect-3arg-lambda]
this->menu_.addAction(
^| this->signalHolder_); | ||
|
|
||
| this->menu_.addAction( | ||
| "Popup Tab", |
There was a problem hiding this comment.
warning: QString(const char*) being called [clazy-qstring-allocations]
| "Popup Tab", | |
| QStringLiteral("Popup Tab"), |
| this->menu_.addAction( | ||
| "Popup Tab", | ||
| getApp()->getHotkeys()->getDisplaySequence(HotkeyCategory::Window, | ||
| "popup", {{"window"}}), |
There was a problem hiding this comment.
warning: QString(const char*) being called [clazy-qstring-allocations]
| "popup", {{"window"}}), | |
| QStringLiteral("popup"), {{"window"}}), |
| } | ||
| }); | ||
|
|
||
| this->menu_.addAction("Duplicate Tab", [this]() { |
There was a problem hiding this comment.
warning: Pass a context object as 2nd addAction parameter [clazy-connect-3arg-lambda]
this->menu_.addAction("Duplicate Tab", [this]() {
^| } | ||
| }); | ||
|
|
||
| this->menu_.addAction("Duplicate Tab", [this]() { |
There was a problem hiding this comment.
warning: QString(const char*) being called [clazy-qstring-allocations]
| this->menu_.addAction("Duplicate Tab", [this]() { | |
| this->menu_.addAction(QStringLiteral("Duplicate Tab"), [this]() { |
| [this, beforeSelectedName]() { | ||
| auto reply = QMessageBox::question( | ||
| this, "Close Visible Tabs to " + beforeSelectedName, | ||
| "Are you sure you want to close all visible tabs to the " + |
There was a problem hiding this comment.
warning: QString(const char*) being called [clazy-qstring-allocations]
src/widgets/helper/NotebookTab.cpp:226:
- beforeSelectedName.toLower() + "?",
+ beforeSelectedName.toLower() + QLatin1String("?"),| }); | ||
|
|
||
| this->closeTabsAfterSelectedAction_ = | ||
| this->closeMultipleTabsMenu_->addAction( |
There was a problem hiding this comment.
warning: Pass a context object as 2nd addAction parameter [clazy-connect-3arg-lambda]
this->closeMultipleTabsMenu_->addAction(
^|
|
||
| this->closeTabsAfterSelectedAction_ = | ||
| this->closeMultipleTabsMenu_->addAction( | ||
| "Close Visible Tabs to " + afterSelectedName, |
There was a problem hiding this comment.
warning: QString(const char*) being called [clazy-qstring-allocations]
| "Close Visible Tabs to " + afterSelectedName, | |
| QLatin1String("Close Visible Tabs to ") + afterSelectedName, |
| "Close Visible Tabs to " + afterSelectedName, | ||
| [this, afterSelectedName]() { | ||
| auto reply = QMessageBox::question( | ||
| this, "Close Visible Tabs to " + afterSelectedName, |
There was a problem hiding this comment.
warning: QString(const char*) being called [clazy-qstring-allocations]
| this, "Close Visible Tabs to " + afterSelectedName, | |
| this, QLatin1String("Close Visible Tabs to ") + afterSelectedName, |
| [this, afterSelectedName]() { | ||
| auto reply = QMessageBox::question( | ||
| this, "Close Visible Tabs to " + afterSelectedName, | ||
| "Are you sure you want to close all visible tabs to the " + |
There was a problem hiding this comment.
warning: QString(const char*) being called [clazy-qstring-allocations]
src/widgets/helper/NotebookTab.cpp:271:
- afterSelectedName + "?",
+ afterSelectedName + QLatin1String("?"),3 participants
No description provided.