-
-
Notifications
You must be signed in to change notification settings - Fork 258
Upgrade to torch 2.9.1 #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Upgrade to torch 2.9.1 #1189
Conversation
|
|
|
upgrading to 2.9.1 works now |
|
Using this PR and manually installing the latest triton-windows (3.5.1-post23) worked fine on SDXL with Windows 11. Editing your post to tick that off. However I would strongly advise we also add a manual cudnn update if you comfortable doing that, theres a tonne of bugs and they werent planning to fix in place (i.e re-release 2.9.1)
No clue lol |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@dxqb pytorch/pytorch#150381 (comment) Pytorch has fixed the gloo bug, but it has to wait for Pytorch 2.10 (same for the cudnn fixes), they arent seeming like they are going to cherry pick and make a 2.9.2 to fix both :( Pytorch 2.10 tracker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add bitsandbytes here but not in requirements-global.txt or requirements-cpu.txt because macOS doesn't support 8-bit optimizers and that's like 90% of what we use bitsandbytes for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good but that needs to be seperate (and tested!), I dont have a AMD gpu ;).
This won't be merged very soon, but I'd suggest we merge it into dev branches that get tested again, as we did with torch 2.8.1
we don't know much about AMD and MPS, but according to a previous thread, torch 2.9 works on ROCM (unlike torch 2.8)
if there are any concerns with upgrading all these packages, we can be more careful and not upgrade the packages in -global.txt