Skip to content

Conversation

@dxqb
Copy link
Collaborator

@dxqb dxqb commented Dec 17, 2025

This should make it easier to implement new models by having the model-specific code less spread around the entire codebase

includes #1210

@dxqb dxqb changed the base branch from master to pr-1210 December 17, 2025 18:55
@dxqb dxqb requested review from Nerogar and O-J1 December 17, 2025 19:02
@dxqb
Copy link
Collaborator Author

dxqb commented Dec 17, 2025

@O-J1 requested review from you because of possible implications of how modules are imported in this PR here:

factory.import_dir("modules/modelSampler", "modules.modelSampler")

ruff would remove regular imports because the modules aren't used anywhere - except that they register themselves when they are imported.

any downsides to importing just all python files that are in these directories?

Copy link
Collaborator

@O-J1 O-J1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might:

  • Get some ruff false positives but I dont believe anything will be auto removed
  • Import errors will still be fatal (same as current)
  • Some impact to startup delays (same as current) because it all has to import and execute, even if it wont be used.

P.S I still think we should try to do conditional imports for the model actually neeed(?) havent ascertained if this would even be possible yet though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants