-
-
Notifications
You must be signed in to change notification settings - Fork 258
Simplify debug code #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Simplify debug code #1212
Conversation
O-J1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but we are missing these 2
the debug code for diffusion models is different from flow matching models, so I only shared code between flow matching models. you could share code between the diffusion models also, but since the main purpose of these PRs is to make it easier to implement any future models, I chose not to do that. It's unlikely that we implement any new diffusion models. |
I'd argue if we are going to refactor we do it for all to ensure we clean up properly, otherwise dont at all, since it just makes it more fractured. |
PR welcome :) Yes, StableDiffusion and StableDiffusionXL could share code between themselves. But that's not worth the effort. |
Part of #1203