-
-
Notifications
You must be signed in to change notification settings - Fork 258
Move to a pixi-based installation
#1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
3c0bb01 to
84a617b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
63ef5d0 to
f390904
Compare
requirements*.txt.pixi-based installation
|
@dxqb As promised, the +/- are in the description of the PR. |
|
|
||
| # Profiling | ||
| scalene==1.5.51 | ||
| scalene==2.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this; version 1.5.51 was really broken on macOS, error on import. Couldn't even launch remote training.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked, only scalene.scalene_profiler.start() and scalene.scalene_profiler.stop() are used. Both of those exist in 2.0.1.
f390904 to
e571100
Compare
5685e79 to
5fc122f
Compare
|
This is now blocked on prefix-dev/pixi#1259. |
71eb91e to
7211167
Compare
7211167 to
5ff0085
Compare
Disdvantages:
venvfolder and the ability to mess with it as needed.pipand the "regular" way of installing packages../launch-ot.sh ...instead ofpython ...source venv/bin/activateis replaced byeval "$(pixi -e [cpu|cuda|rocm] shell-hook)"or prefixing each command withpixi run -e [cuda|rocm|cpu]requirements*.txtfiles, and if we keep, they have to be kept in sync with the TOML.Advantages:
pixi, you can runpixi run -e [cuda|rocm|cpu] <command>, it will take care of installation running the command from beginning to end.pixi.lock. Works wonders for reproducibility. To update, just usepixi update.libglandtkfor linux: No more need forsudoanymore, only hard dep is eitherwgetorcurl.Decisions to make:
requirements*.txtToDos for this PR:
pixiand then dopixi install -e ...orpixi run -e ...(or we can get rid of the install script entirely).After merging:
requirements*.txt.