-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Revert/main #18729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert/main #18729
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,18 +40,18 @@ jobs: | |
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x] | ||
| host: [macos-13, windows-latest, ubuntu-latest] | ||
| host: [macos-latest, windows-latest, ubuntu-latest] | ||
| exclude: | ||
| - node-version: 18.x | ||
| host: macos-13 | ||
| host: macos-latest | ||
| - node-version: 18.x | ||
| host: windows-latest | ||
| - node-version: 20.x | ||
| host: macos-13 | ||
| host: macos-latest | ||
| - node-version: 20.x | ||
| host: windows-latest | ||
| include: | ||
| - host: macos-13 | ||
| - host: macos-latest | ||
| target: x86_64-apple-darwin | ||
| - host: windows-latest | ||
| target: x86_64-pc-windows-msvc | ||
|
|
@@ -63,7 +63,7 @@ jobs: | |
| runs-on: ${{ matrix.host }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
| uses: actions/checkout@v5 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: Short answer
Key differences and compatibility notes
If you want, tell me which workflows or runner types you use (hosted vs self-hosted, container vs standard) and I’ll check for any specific breaking issues. Sources 🌐 Web query:
💡 Result: Short summary of breaking changes in actions/checkout@v6:
Notes: the maintainers describe this as non-breaking for typical workflows, but some platform-specific or custom SSH/PAT setups may need review; see the discussion/issue threads for edge cases. [3] Sources: [1] actions/checkout README (v6) — GitHub. [2] GitHub Marketplace listing for Checkout (v6). [3] GitHub issue discussion about v6 behavior. [4] v6 release notes. 应该有文档说明为什么从 v6 降级到 v5 根据官方文档, 降级到 v5 不是常见做法,请补充说明原因。可能的原因包括:
请在代码注释或 PR 描述中说明这个版本选择的具体原因。 🤖 Prompt for AI Agents |
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v4 | ||
| with: | ||
|
|
@@ -74,7 +74,7 @@ jobs: | |
| node-version: ${{ matrix.node-version }} | ||
| cache: 'pnpm' | ||
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile | ||
| run: pnpm -r install --frozen-lockfile | ||
| - name: Lint | ||
| run: pnpm lint | ||
| - name: Download artifact bindings-${{ matrix.target }} | ||
|
|
@@ -110,7 +110,14 @@ jobs: | |
| env: | ||
| NODE_OPTIONS: --max_old_space_size=4096 | ||
| - name: test | ||
| run: pnpm run pretest:ci && pnpm test | ||
| #TODO: 需要优化测试流程,目前 macos 无法正常执行测试,暂时跳过,等待后续优化 | ||
| shell: bash | ||
| run: | | ||
| if [ "${{ matrix.host }}" = "macos-latest" ]; then | ||
| pnpm -r --aggregate-output --filter=./packages/* --filter=./tests --filter=!@tarojs/components test:ci | ||
| else | ||
| pnpm test | ||
| fi | ||
|
Comment on lines
112
to
+120
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. macOS 测试绕过方案需要更明确的文档和跟踪 当前的条件测试逻辑为 macOS 排除了
建议:
您是否需要我帮助创建跟踪此技术债的 issue? 🤖 Prompt for AI Agents |
||
| # 以下 coverage 流程通过 artifact 拆分文件作为单独 job 上传时间损耗过长,因此在在 node test 后直接继续执行 | ||
| - name: Upload [taro-cli] coverage to Codecov | ||
| uses: codecov/codecov-action@v5 | ||
|
|
@@ -151,7 +158,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
| uses: actions/checkout@v5 | ||
| - name: Setup Rust | ||
| uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
GitHub Actions checkout v5 v6 breaking changes differences💡 Result:
Summary — main differences / breaking changes between actions/checkout v5 and v6
Credentials persistence: v6 no longer writes the auth token into .git/config; it stores credentials in a separate file under $RUNNER_TEMP and uses git includeIf to reference it. This improves credential security and isolates creds from repository git config. No workflow changes are required for most users — ordinary git fetch/push still work. [1][2]
Runner/minimum requirements: v5 bumped the action runtime to Node.js 24 and required Actions Runner >= v2.327.1; v6 also documents Node 24 support and requires Actions Runner >= v2.329.0 for running authenticated git commands from inside a Docker container action. If you run container actions that need authenticated git access, ensure your runner meets the v6 minimum. [1][2]
Behavior impact & migration: because v6 uses includeIf and a separate cred file, most existing workflows (including git push using the built-in token) continue to work without changes. Edge cases include custom SSH-key setups or nonstandard runner environments — verify those workflows and, for private secondary repos, continue to use a PAT when needed. v6 also added worktree support for the new persist-credentials includeIf in patch releases. [1][3]
References
🌐 Web query:
GitHub Actions checkout v5 security vulnerabilities maintenance status💡 Result:
Short answer: actions/checkout@v5 is a maintained release (v5.0.0 published Aug 11, 2025) but the official repo says GitHub is not accepting general contributions and will focus internal resources while still providing security fixes and major-breaking-change fixes. For credential/security improvements you should consider moving to v6 (which adds improved credential storage). [1][2][3][4]
Details (concise)
Sources:
🌐 Web query:
GitHub Actions checkout version 5 end of support deprecated💡 Result:
Short answer: actions/checkout@v5 is not marked as deprecated or end-of-support in the official repo/Marketplace, but v6 is available and contains security/credential improvements — you should upgrade to v6 when your runners meet the minimum version requirements. See the official repo and Marketplace release notes for v5→v6 details. [1][2]
Sources:
确认 actions/checkout 版本降级的原因
从 v6 降级到 v5 可能源于运行环境限制。v5 仍在维护中并会收到安全更新,但 v6 需要 Actions Runner >= v2.329.0。建议确认:
v6 相比 v5 的主要改进是凭证存储方式(独立于 git config),这在安全性上有所提升。如果运行环境支持,建议升级到 v6;否则 v5 作为临时方案是可接受的。
🤖 Prompt for AI Agents