updated GetRequestingParty APIs to support Basic client authentication#324
Conversation
|
Hi, can you please fetch the changes from the main branch into your branch? That should fix the error in the test :) |
…/permission-basic-auth
|
Hi, I have just updated the PR branch from main branch |
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 76.60% 76.66% +0.05%
==========================================
Files 4 4
Lines 1962 1967 +5
==========================================
+ Hits 1503 1508 +5
Misses 319 319
Partials 140 140
Continue to review full report at Codecov.
|
|
My review comments won't save due to some bug. So here it is again: If the clientSecret is only needed, when checking basic auth stuff. The API gets harder to use, as the consumer of the API might not know when the clientSecret can be empty and when it needs to be filled. |
Solution for #323
All GetRequestingParty APIs can now be used using Basic authorization header (clientID and clientSecret), or as previous using Bearer authorization header (token).
The basic authentication is useful for being able to request the evaluation of a user token (provided into SubjectToken) using a service account.