CSTACKEX-34: Upgrade to framework classes design #13
Conversation
rajiv-jain-netapp
requested review from
piyush5netapp,
sandeeplocharla and
suryag1201
| * | ||
| * @param values | ||
| */ | ||
| public void updateStorageVolume(Map<String,String> values) |
There was a problem hiding this comment.
We can have model where we have nested hierarchy of the file and volume model combined instead of map. This will help us know what fields are required for what operation from readability perspective.
|
|
||
| private static final Logger s_logger = (Logger) LogManager.getLogger(StorageStrategy.class); | ||
|
|
||
| protected enum PROTOCOLS |
There was a problem hiding this comment.
OntapStorage also has protocol, we can remove this
| * createNameSpace for Nvme/TCP and Nvme/FC protocol | ||
| * @param values | ||
| */ | ||
| abstract public CloudStackVolume createCloudStackVolume(Map<String,String> values); |
There was a problem hiding this comment.
as per discussion, we should pass those new models as a param also instead of map in required methods
|
|
||
| public class AccessGroup { | ||
|
|
||
| Igroup igroup; |
There was a problem hiding this comment.
please specify as private because we already have a getter with public
|
|
||
| public class CloudStackVolume { | ||
|
|
||
| FileInfo file; |
| public class AccessGroup { | ||
|
|
||
| Igroup igroup; | ||
| Policy policy; |
rajiv-jain-netapp
left a comment
rajiv-jain-netapp
left a comment
There was a problem hiding this comment.
Incorporated review comments
| * | ||
| * @param values | ||
| */ | ||
| public void updateStorageVolume(Map<String,String> values) |
|
|
||
| private static final Logger s_logger = (Logger) LogManager.getLogger(StorageStrategy.class); | ||
|
|
||
| protected enum PROTOCOLS |
| * createNameSpace for Nvme/TCP and Nvme/FC protocol | ||
| * @param values | ||
| */ | ||
| abstract public CloudStackVolume createCloudStackVolume(Map<String,String> values); |
| ISCSI | ||
| } | ||
|
|
||
| public static final String NFS = "nfs"; |
There was a problem hiding this comment.
These 2 constants can be deleted
sandeeplocharla
left a comment
sandeeplocharla
left a comment
There was a problem hiding this comment.
Please see if the constants can be removed as part of the next PR
Description
Updated the class structure for the framwork classes
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?