624 new resource netapp ontap protocols fpolicy event #626
Conversation
suhasbshekar
requested review from
carchi8py,
chuyich and
wenjun666
as code owners
There was a problem hiding this comment.
provider.tf should be a link pointing to https://github.com/NetApp/terraform-provider-netapp-ontap/blob/integration/main/examples/provider/provider.tf
If there are some new clusters, please update the canvas on the dev-terraform-ontap channel
There was a problem hiding this comment.
it is still a file not a link
There was a problem hiding this comment.
This file should be the link pointing to https://github.com/NetApp/terraform-provider-netapp-ontap/blob/integration/main/examples/provider/variables.tf
There was a problem hiding this comment.
It is still a file not a link.
| stringvalidator.OneOf("cifs", "nfsv3", "nfsv4"), | ||
| }, | ||
| }, | ||
| "file_operations": schema.SetAttribute{ |
There was a problem hiding this comment.
https://docs.netapp.com/us-en/ontap-restapi-96/ontap/swagger-ui/index.html#/NAS/fpolicy_event_create
The file_operations is a list. Can you double check?
There was a problem hiding this comment.
yes, we add Set for a list in terraform so that it supports schema appropriately
There was a problem hiding this comment.
if orders does not matter, use set.
| MarkdownDescription: "File operations to be monitored", | ||
| Optional: true, | ||
| }, | ||
| "filters": schema.SetAttribute{ |
There was a problem hiding this comment.
Same as filters. It should be a list. https://docs.netapp.com/us-en/ontap-restapi-96/ontap/swagger-ui/index.html#/NAS/fpolicy_event_create
There was a problem hiding this comment.
yes, we add Set for a list in terraform so that it supports schema appropriately
| MarkdownDescription: "Filters to be applied for the specified file operations", | ||
| Optional: true, | ||
| }, | ||
| "volume_monitoring": schema.BoolAttribute{ |
There was a problem hiding this comment.
If it is not provided, there will be a value to be set.
Can this add:
PlanModifiers: []planmodifier.Bool{
boolplanmodifier.UseStateForUnknown(),
},
There was a problem hiding this comment.
actually the API adds false as default, updated accordingly
There was a problem hiding this comment.
On the doc, "If not specified in POST, the following default property values are assigned:
file_operations.* - false
filters.* - false
volume-monitoring - false"
Which means the paramters do not have to be set with default values, the API will take the call without these default values and the response will give the full set with the default values if the parameters are not set in the POST.
chuyich
left a comment
chuyich
left a comment
There was a problem hiding this comment.
Please double check the parameters on the doc https://docs.netapp.com/us-en/ontap-restapi-96/ontap/swagger-ui/index.html#/NAS/fpolicy_event_create
|
Please check the ACC run in pipeline, it has updated list of tests |
…otocols_fpolicy_event
…otocols_fpolicy_event
| return f | ||
| } | ||
|
|
||
| // // convertFileOperationsFromStruct converts FpolicyEventFileOperations struct to types.Set |
There was a problem hiding this comment.
Remove if not needed. If need, add comments.
https://github.com/NetApp/terraform-provider-netapp-ontap into 624-new-resource-netapp-ontap_protocols_fpolicy_event
3 participants
No description provided.