fix: resolve security group processing bug and add repo config files #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix security group egress loop incorrectly nested inside ingress loop in vpc.py - Add missing imports (Table, asdict, get_theme_dir) causing runtime errors - Replace bare except clauses with specific exception types - Remove unused imports and fix f-strings without placeholders - Fix ambiguous variable names (l -> lis) in test files - Mark intentionally unused variables with underscore prefix - Mark test fixture AWS example IDs as allowlisted secrets - Make scripts with shebangs executable Fixes security group data processing bug that caused egress rules to be processed N times (once per ingress rule) instead of once.
- Add .gitattributes for line ending normalization and binary handling - Add .editorconfig for consistent formatting across editors - Add .markdownlint.yaml for markdown linting rules - Add .commitlintrc.yaml for conventional commit enforcement - Add .github/dependabot.yml for automated dependency updates - Add .github/CODEOWNERS for code ownership assignments - Add .github/PULL_REQUEST_TEMPLATE.md for standardized PR descriptions - Update .pre-commit-config.yaml with named hooks, shellcheck, markdownlint - Update .gitignore with pyright cache and coverage file patterns - Auto-fix markdown files (trailing whitespace, newlines)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug where security group egress rules were processed multiple times due to incorrect loop nesting. Also added standard repository configuration files (pre-commit hooks, linting, dependabot) to make contributing easier.
Type of Change
Changes
Bug Fixes
vpc.py, causing egress rules to be processed N times instead of once. Moved it to the correct scope.Table,asdict,get_theme_dir) that were causing runtime errorsexcept:with specific exception types (e.g.,except ValueError:,except KeyError:)ltolisin test files for clarityRepository Configuration
Added the following config files:
.gitattributes- line ending normalization.editorconfig- consistent indentation/formatting.markdownlint.yaml- markdown linting.commitlintrc.yaml- conventional commit validation.github/dependabot.yml- automated dependency updates.github/CODEOWNERS- ownership for PR reviews.github/PULL_REQUEST_TEMPLATE.md- PR templateUpdated:
.pre-commit-config.yaml- addedname:fields, shellcheck, markdownlint hooks.gitignore- added pyright cache, coverage filesHousekeeping
_to indicate intentional non-useTesting
pytest tests/)pre-commit run --all-files)Test Commands Run
Checklist
Security Considerations
Additional Notes
Commits included:
5acd3a8fix(core): fix critical bugs and code quality issues24a9c25chore(repo): add repository scaffolding and configuration filesThe security group bug was the main driver for this PR - wanted to get that fix in along with some repo hygiene.