Skip to content

Conversation

@kwin
Copy link
Member

@kwin kwin commented Apr 10, 2025

Trigger from JMX/Touch UI leveraging server-sent events Consume the messages in JQuery UI/Coral UI dialog

This closes #801

@kwin kwin requested a review from ghenzler April 10, 2025 07:05
@kwin kwin force-pushed the feature/asynchronous-execution branch from 8e2e8c9 to 2fa2a93 Compare April 10, 2025 07:07
Job job = jobManager.getJobById(jobId);
if (job == null) {
// finished job or unknown job not to distinguish, as only failed jobs are kept in the history
LOG.debug("No job found with id {}", jobId);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud
}
});
if (!isActive) {
LOG.debug("Haven't found job with id {}, probably already finished processing it", jobId);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud
@Override
protected void doGet(final HttpServletRequest req, final HttpServletResponse resp) throws ServletException, IOException {
acToolUiService.doGet(req, resp, req.getRequestURI(), false);
acToolUiService.doGet(req, resp, getWebConsoleRoot(req) + "/" + LABEL, false);

Check notice

Code scanning / SonarCloud

Exceptions should not be thrown from servlet methods Low

Handle the following exceptions that could be thrown by "doGet": ServletException, IOException. See more on SonarQube Cloud
@kwin kwin force-pushed the feature/asynchronous-execution branch 2 times, most recently from 21d2af7 to a5d34f9 Compare April 10, 2025 12:06
Trigger from JMX/Touch UI leveraging server-sent events
Consume the messages in JQuery UI/Coral UI dialog

This closes #801
@kwin kwin force-pushed the feature/asynchronous-execution branch from a5d34f9 to e8b8f7c Compare April 10, 2025 15:48
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.3% Coverage on New Code (required ≥ 31%)

See analysis details on SonarQube Cloud

@kwin kwin merged commit fd3d684 into develop Apr 10, 2025
10 of 11 checks passed
@kwin kwin deleted the feature/asynchronous-execution branch April 10, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Touch UI action: "Apply ACTool Configuration" times out in AEMaaCS

1 participant