fix: correctly map several media types which are the same in before/after but has wildcards #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter but has wildcards
JayLim2
reviewed
May 26, 2025
...er/resources/wildcard-content-schema-media-type-combined-with-specific-media-type/after.json
Show resolved
Hide resolved
- add full media type matches with first priority with corresponding tests - remove reduntant 'should map wildcard fallback after exact matches' test
JayLim2
approved these changes
May 28, 2025
CountRedClaw
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify content schema media type mapping logic:
remove media type change from 'Ref with array to self - cycled path' unit test, since it is not really relevant for the cases being tested
add unit tests for content schema media type mapping
add unit test with case from the issue [FE] Combination of url change and application/octet-stream in response is wrongly calculated as breaking change by system #18