-
Notifications
You must be signed in to change notification settings - Fork 0
fix: add compatibility suite tests for description and summary override via Reference Object for OAS 3.1 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5bb6840
feat: Reference object
makeev-pavel 0805fcc
fix: rollback json-crawl version change
b41ex f7f805c
chore: merge branch 'develop' into feature/ref-obj
b41ex af2efb1
feat: Added compatibility-suites tests
makeev-pavel 62e9d0f
feat: Updated paths compatibility-suites tests
makeev-pavel 5ee5a96
feat: Fixed tests paths
makeev-pavel 62aed7e
feat: Fixed paths
makeev-pavel d5c5a06
chore: set dev versions for dependencies
b41ex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { runRefObjectDescriptionTests } from './templates/reference-object-31.template' | ||
|
|
||
| const SUITE_ID = 'headers' | ||
| const PATH_TO_HEADER_DESCRIPTION = ['paths', '/path1', 'get', 'responses', '200', 'headers', 'X-Rate-Limit', 'description'] | ||
| const PATH_TO_COMPONENT_DESCRIPTION = ['components', 'headers', 'X-Rate-Limit', 'description'] | ||
b41ex marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| describe('Reference object. Headers. Description fields in ref object', () => { | ||
| runRefObjectDescriptionTests(SUITE_ID, PATH_TO_HEADER_DESCRIPTION, PATH_TO_COMPONENT_DESCRIPTION) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| import { compareFiles, TEST_DEFAULTS_DECLARATION_PATHS } from '../utils' | ||
| import { diffsMatcher } from '../../helper/matchers' | ||
| import { annotation, breaking, deprecated, DiffAction, nonBreaking, unclassified } from '../../../src' | ||
| import { runRefObjectDescriptionTests } from './templates/reference-object-31.template' | ||
|
|
||
| const SUITE_ID = 'operation-parameters' | ||
|
|
||
|
|
@@ -338,7 +339,6 @@ describe('Openapi3 Operation Parameters', () => { | |
| }), | ||
| ])) | ||
| }) | ||
|
|
||
|
|
||
| // TODO: fixme | ||
| test.skip('Mark primitive parameter as exploded', async () => { | ||
|
|
@@ -724,3 +724,8 @@ describe('Openapi3 Operation Parameters', () => { | |
| }) | ||
| }) | ||
| }) | ||
|
|
||
| const PATH_TO_COMPONENT_DESCRIPTION = ['components', 'parameters', 'status', 'description'] | ||
|
||
| describe('Reference object. Operation parameters. Description fields in ref object', () => { | ||
| runRefObjectDescriptionTests(SUITE_ID, [...OPERATION_PARAMETERS_PATH, 0, 'description'], PATH_TO_COMPONENT_DESCRIPTION) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { runRefObjectDescriptionTests } from './templates/reference-object-31.template' | ||
|
|
||
| const SUITE_ID = 'request-body' | ||
| const PATH_TO_HEADER_DESCRIPTION = ['paths', '/path1', 'post', 'requestBody', 'description'] | ||
b41ex marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| const PATH_TO_COMPONENTS_DESCRIPTION = ['components', 'requestBodies', 'rb1', 'description'] | ||
|
|
||
| describe('Reference object. Request body. Description fields in ref object', () => { | ||
| runRefObjectDescriptionTests(SUITE_ID, PATH_TO_HEADER_DESCRIPTION, PATH_TO_COMPONENTS_DESCRIPTION) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.