feat: nullable in OAS 3.0 is equivalent to union with null type in 3.1 #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b41ex
changed the title
b41ex
changed the title
b41ex
requested changes
Sep 30, 2025
...rces/openapi-3_0-to-3_1/could-compare-overridden-description-via-reference-object/after.json
Show resolved
Hide resolved
test/oas-30-to-31.test.ts
Outdated
| }) | ||
|
|
||
| describe('Comparison nullable and null type', () => { | ||
| test('could compare nullable to anyOf', () => { |
There was a problem hiding this comment.
'nullable is equivalent to anyOf with null type'
# Conflicts: # package.json
JayLim2
approved these changes
Oct 1, 2025
src/openapi/openapi3.schema.ts
Outdated
| ) | ||
|
|
||
| const inputOrigins = valueWithoutNullable[originsFlag] as Record<PropertyKey, unknown> | undefined | ||
| const nullTypeOrigins = nullTypeObject[originsFlag] as Record<PropertyKey, unknown> | undefined ?? {} |
There was a problem hiding this comment.
it's better to check type explicitly with isObject
There was a problem hiding this comment.
it's not necessary to cast type if you checked it explicitly. If it doesn't work, maybe you have to extract it to fixed const before checking.
It increases code size, but it is more type safe
b41ex
approved these changes
Oct 2, 2025
JayLim2
approved these changes
Oct 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.