feat: path change due to moving a prefix from server.url to path classified as annotation #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sified as annotation
…sified as annotation
github-actions
bot
added
bug
makeev-pavel
reviewed
Oct 6, 2025
JayLim2
reviewed
Oct 6, 2025
|
|
||
| export function hidePathParamNames(path: string): string { | ||
| return path.replace(PATH_PARAMETER_REGEXP, PATH_PARAM_UNIFIED_PLACEHOLDER) | ||
| } |
There was a problem hiding this comment.
I have no comments but because all these manipulations like magic. So I would like to request some documentation for these operations because there a lot of utility functions calling each other and it's difficult to understand whole the algorithm
There was a problem hiding this comment.
Added jsdoc for path mapper.
| [obj[aggregatedDiffProperty]] = childrenDiffs | ||
| }else{ | ||
| // no diffs- no aggregated diffs get assigned | ||
| } |
There was a problem hiding this comment.
do we really need empty else?
and you may format the code
There was a problem hiding this comment.
Else is not empty, it contains comment:) This is to emphasize/remind the reader that in this case to aggregated diffs will be added.
Formatted code.
… and servers array in root object or path item object
…api-processor to avoid code duplication
github-actions
bot
added
the
documentation
…correct (has no url property)
makeev-pavel
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: utility recursive method to aggregate diffs with rollup in merged tree