fix: do not allow to publish specifications with operations with empty path parameter name

Author: b41ex

src/apitypes/rest/rest.operations.ts

@@ -66,6 +66,11 @@ export const buildRestOperations: OperationsBuilder<OpenAPIV3.Document> = async
 
   const componentsHashMap = new Map<string, string>()
   for (const path of Object.keys(paths)) {
+    // Validate path parameters: empty parameter names are not allowed
+    if (path.includes('{}')) {
+      throw new Error(`Invalid path '${path}': path parameter name could not be empty`)
+    }
+
     const pathData = paths[path]
     if (typeof pathData !== 'object' || !pathData) { continue }
 

test/bugs.test.ts

@@ -17,6 +17,8 @@
 import { API_AUDIENCE_INTERNAL, API_KIND } from '../src'
 import { Editor, LocalRegistry } from './helpers'
 
+import { describe, test, expect } from '@jest/globals'
+
 const bugsPackage = LocalRegistry.openPackage('bugs')
 const swaggerPackage = LocalRegistry.openPackage('basic_swagger')
 const migrationBug = LocalRegistry.openPackage('migration_bug')
@@ -357,4 +359,16 @@ describe('Operation Bugs', () => {
     const operationKeys = Array.from(result.operations.keys())
     expect(operationKeys[0]).toEqual('paths1-get')
   })
+
+  test('Should throw error if path parameter name is empty', async () => {
+    const pkg = LocalRegistry.openPackage('empty-path-parameter')
+
+    await expect(pkg.publish(pkg.packageId, {
+      packageId: pkg.packageId,
+      version: 'v1',
+      files: [
+        { fileId: 'spec.json' },
+      ],
+    })).rejects.toThrow('Invalid path \'/res/data/{}\': path parameter name could not be empty')
+  })
 })