feat: support for reusable pathItems definitions in components for OAS 3.1 #35
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
makeev-pavel
changed the title
makeev-pavel
requested review from
CountRedClaw,
JayLim2 and
b41ex
and removed request for
CountRedClaw
There was a problem hiding this comment.
Please add a test in 'Document Group test' that makes sure that we are properly getting rid of operations that are not included in the group. Also it would be nice to check that we can handle mixed use of the regular pathItems and the referenced ones in one document.
added 2 tests |
# Conflicts: # package.json
| return typeof value === 'object' && value !== null | ||
| } | ||
|
|
||
| export const getSymbolValueIfDefined = <T extends object>( |
There was a problem hiding this comment.
I do not get, what is the benefit to have this method compared to just using obj[symbol]?
There was a problem hiding this comment.
The logic is simple - type conversion and validation in a separate place.
# Conflicts: # .github/super-linter.env
There was a problem hiding this comment.
We have a logic that reduces path items to particular operation in a single-operation specification during build build type, but there's no corresponding test.
I believe we should add one.
There's a similar test for reducedSourceSpecifications build type ('should have documents stripped of operations other than from provided group'), but not build build type.
b41ex
changed the title
No description provided.