fix: collect only security and security schema changes relevant for the operation #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration when creating single operation specification
…ecurity-changes-classification
…are no components
JayLim2
reviewed
Oct 27, 2025
|
|
||
| return { | ||
| asymmetricMatch: (actual: SecuritySchemesObject): boolean => { | ||
| if (!actual || typeof actual !== 'object') { |
There was a problem hiding this comment.
how is this possible if actual receives only objective type?
| version: 1.0.0 | ||
| security: | ||
| - OAuth2: | ||
| - read |
There was a problem hiding this comment.
changed both schema key and array. is it correct?
| title: Security Test | ||
| version: 1.0.0 | ||
| security: | ||
| - ApiKeyAuth: [] |
There was a problem hiding this comment.
empty array here is a little bit confusing. can't we get rid of it if it has no effect on the case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: collect only security and security schema changes relevant for the operation
fix: only include root security and security schemes relevant for operation when creating single operation specification