Skip to content

Commit 0c1f1fd

Browse files
vOriginsvOrigins
authored
refactor(access-control): remove release manager role from user settings
The release manager role is no longer needed in the access control settings. This commit removes the related checkbox and updates the corresponding tests to reflect the change.
1 parent 3c0dcef commit 0c1f1fd

File tree

2 files changed

+7
-17
lines changed

2 files changed

+7
-17
lines changed

‎src/packages/portal/pages/PortalPage/BaseVersionPage/PackageSettingsPage/AccessControlTab/AcUserRow.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ export class AcUserRow extends TableRow {
88
readonly userCell = new TableCell(this.mainLocator.getByTestId('Cell-user'), this.componentName, 'name cell')
99
readonly adminChx = new Checkbox(this.mainLocator.getByTestId('Cell-admin').getByRole('checkbox'), this.componentName, 'admin checkbox')
1010
readonly ownerChx = new Checkbox(this.mainLocator.getByTestId('Cell-owner').getByRole('checkbox'), this.componentName, 'owner checkbox')
11-
readonly releaseManagerChx = new Checkbox(this.mainLocator.getByTestId('Cell-release-manager').getByRole('checkbox'), this.componentName, 'release manager checkbox')
1211
readonly editorChx = new Checkbox(this.mainLocator.getByTestId('Cell-editor').getByRole('checkbox'), this.componentName, 'editor checkbox')
1312
readonly viewerChx = new Checkbox(this.mainLocator.getByTestId('Cell-viewer').getByRole('checkbox'), this.componentName, 'viewer checkbox')
1413
readonly deleteBtn = new Button(this.mainLocator.getByTestId('DeleteButton'), this.componentName, 'delete button')

‎src/tests/portal/03-access-control/3.0-general.spec.ts‎

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ test.describe('03.0 Access Control. General.', () => {
4141

4242
await expect(accessControlTab.getUserRow(TEST_USER_1.name).adminChx).not.toBeChecked()
4343
await expect(accessControlTab.getUserRow(TEST_USER_1.name).ownerChx).not.toBeChecked()
44-
await expect(accessControlTab.getUserRow(TEST_USER_1.name).releaseManagerChx).not.toBeChecked()
4544
await expect(accessControlTab.getUserRow(TEST_USER_1.name).editorChx).not.toBeChecked()
4645
await expect(accessControlTab.getUserRow(TEST_USER_1.name).viewerChx).toBeChecked()
4746
})
@@ -53,7 +52,6 @@ test.describe('03.0 Access Control. General.', () => {
5352

5453
await expect(accessControlTab.getUserRow(TEST_USER_2.name).adminChx).not.toBeChecked()
5554
await expect(accessControlTab.getUserRow(TEST_USER_2.name).ownerChx).not.toBeChecked()
56-
await expect(accessControlTab.getUserRow(TEST_USER_2.name).releaseManagerChx).not.toBeChecked()
5755
await expect(accessControlTab.getUserRow(TEST_USER_2.name).editorChx).toBeChecked()
5856
await expect(accessControlTab.getUserRow(TEST_USER_2.name).viewerChx).not.toBeChecked()
5957
})
@@ -65,7 +63,6 @@ test.describe('03.0 Access Control. General.', () => {
6563

6664
await expect(accessControlTab.getUserRow(TEST_USER_3.name).adminChx).not.toBeChecked()
6765
await expect(accessControlTab.getUserRow(TEST_USER_3.name).ownerChx).toBeChecked()
68-
await expect(accessControlTab.getUserRow(TEST_USER_3.name).releaseManagerChx).not.toBeChecked()
6966
await expect(accessControlTab.getUserRow(TEST_USER_3.name).editorChx).not.toBeChecked()
7067
await expect(accessControlTab.getUserRow(TEST_USER_3.name).viewerChx).not.toBeChecked()
7168
})
@@ -77,7 +74,6 @@ test.describe('03.0 Access Control. General.', () => {
7774

7875
await expect(accessControlTab.getUserRow(TEST_USER_4.name).adminChx).toBeChecked()
7976
await expect(accessControlTab.getUserRow(TEST_USER_4.name).ownerChx).not.toBeChecked()
80-
await expect(accessControlTab.getUserRow(TEST_USER_4.name).releaseManagerChx).not.toBeChecked()
8177
await expect(accessControlTab.getUserRow(TEST_USER_4.name).editorChx).not.toBeChecked()
8278
await expect(accessControlTab.getUserRow(TEST_USER_4.name).viewerChx).not.toBeChecked()
8379
})
@@ -183,22 +179,22 @@ test.describe('03.0 Access Control. General.', () => {
183179

184180
await portalPage.gotoPackage(PKG_P_UAC_G_MULT1_N, SETTINGS_TAB_USERS)
185181

186-
await test.step('Add "Release Manager" role by checkbox clicking', async () => {
187-
await accessControlTab.getUserRow(testUserName).releaseManagerChx.click()
182+
await test.step('Add "Editor" role by checkbox clicking', async () => {
183+
await accessControlTab.getUserRow(testUserName).editorChx.click()
188184

189-
await expect(accessControlTab.getUserRow(testUserName).releaseManagerChx).toBeChecked()
185+
await expect(accessControlTab.getUserRow(testUserName).editorChx).toBeChecked()
190186
})
191187

192-
await test.step('Remove "Release Manager" role by checkbox clicking', async () => {
193-
await accessControlTab.getUserRow(testUserName).releaseManagerChx.click()
188+
await test.step('Remove "Editor" role by checkbox clicking', async () => {
189+
await accessControlTab.getUserRow(testUserName).editorChx.click()
194190

195-
await expect(accessControlTab.getUserRow(testUserName).releaseManagerChx).not.toBeChecked()
191+
await expect(accessControlTab.getUserRow(testUserName).editorChx).not.toBeChecked()
196192
})
197193

198194
await test.step('Undo changes', async () => {
199195
await portalPage.snackbar.undoBtn.click()
200196

201-
await expect(accessControlTab.getUserRow(testUserName).releaseManagerChx).toBeChecked()
197+
await expect(accessControlTab.getUserRow(testUserName).editorChx).toBeChecked()
202198
})
203199
})
204200

@@ -219,7 +215,6 @@ test.describe('03.0 Access Control. General.', () => {
219215

220216
await expect(accessControlTab.getUserRow(testUserName).adminChx).toBeChecked()
221217
await expect(accessControlTab.getUserRow(testUserName).ownerChx).not.toBeChecked()
222-
await expect(accessControlTab.getUserRow(testUserName).releaseManagerChx).not.toBeChecked()
223218
await expect(accessControlTab.getUserRow(testUserName).editorChx).toBeChecked()
224219
await expect(accessControlTab.getUserRow(testUserName).viewerChx).toBeChecked()
225220
})
@@ -243,7 +238,6 @@ test.describe('03.0 Access Control. General.', () => {
243238

244239
await expect(accessControlTab.getUserRow(testUserName).adminChx).not.toBeChecked()
245240
await expect(accessControlTab.getUserRow(testUserName).ownerChx).not.toBeChecked()
246-
await expect(accessControlTab.getUserRow(testUserName).releaseManagerChx).not.toBeChecked()
247241
await expect(accessControlTab.getUserRow(testUserName).editorChx).toBeChecked()
248242
await expect(accessControlTab.getUserRow(testUserName).viewerChx).toBeChecked()
249243
})
@@ -267,7 +261,6 @@ test.describe('03.0 Access Control. General.', () => {
267261

268262
await expect(accessControlTab.getUserRow(testUserName).adminChx).toBeChecked()
269263
await expect(accessControlTab.getUserRow(testUserName).ownerChx).not.toBeChecked()
270-
await expect(accessControlTab.getUserRow(testUserName).releaseManagerChx).not.toBeChecked()
271264
await expect(accessControlTab.getUserRow(testUserName).editorChx).toBeChecked()
272265
await expect(accessControlTab.getUserRow(testUserName).viewerChx).not.toBeChecked()
273266
})
@@ -292,12 +285,10 @@ test.describe('03.0 Access Control. General.', () => {
292285

293286
await expect(accessControlTab.getUserRow(testUser2Name).adminChx).not.toBeChecked()
294287
await expect(accessControlTab.getUserRow(testUser2Name).ownerChx).not.toBeChecked()
295-
await expect(accessControlTab.getUserRow(testUser2Name).releaseManagerChx).not.toBeChecked()
296288
await expect(accessControlTab.getUserRow(testUser2Name).editorChx).toBeChecked()
297289
await expect(accessControlTab.getUserRow(testUser2Name).viewerChx).not.toBeChecked()
298290
await expect(accessControlTab.getUserRow(testUser3Name).adminChx).not.toBeChecked()
299291
await expect(accessControlTab.getUserRow(testUser3Name).ownerChx).not.toBeChecked()
300-
await expect(accessControlTab.getUserRow(testUser3Name).releaseManagerChx).not.toBeChecked()
301292
await expect(accessControlTab.getUserRow(testUser3Name).editorChx).toBeChecked()
302293
await expect(accessControlTab.getUserRow(testUser3Name).viewerChx).not.toBeChecked()
303294
})

0 commit comments

Comments
 (0)