Skip to content

Commit ee8a106

Browse files
iurii-golovinskiiiurii-golovinskii
authored
refactor: rename semi-breaking changes to risky in FE code (#15)
1 parent 0c1f1fd commit ee8a106

File tree

18 files changed

+83
-83
lines changed

18 files changed

+83
-83
lines changed

‎src/packages/portal/pages/PortalPage/ComparisonPages/BaseCompareToolbar.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ export abstract class BaseCompareToolbar {
88
readonly breadcrumbs = new Breadcrumbs(this.locator.getByTestId('ComparedPackagesBreadcrumbs'), 'Comparison')
99
readonly backBtn = new Button(this.locator.getByTestId('BackButton'), 'Back')
1010
readonly packageSlt = new ComparisonPagePackageSelect(this.page)
11-
readonly breakingChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-breaking'), 'Breaking Сhanges filter')
12-
readonly semiBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-semi-breaking'), 'Changes Requiring Attention filter')
13-
readonly deprecatedChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-deprecated'), 'Deprecated Сhanges filter')
14-
readonly nonBreakingChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-non-breaking'), 'Non-breaking Сhanges filter')
15-
readonly annotationChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-annotation'), 'Annotation Сhanges filter')
16-
readonly unclassifiedChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-unclassified'), 'Unclassified Сhanges filter')
11+
readonly breakingChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-breaking'), 'Breaking changes filter')
12+
readonly riskyChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-risky'), 'Changes Requiring Attention filter')
13+
readonly deprecatedChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-deprecated'), 'Deprecated changes filter')
14+
readonly nonBreakingChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-non-breaking'), 'Non-breaking changes filter')
15+
readonly annotationChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-annotation'), 'Annotation changes filter')
16+
readonly unclassifiedChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-unclassified'), 'Unclassified changes filter')
1717

1818
protected constructor(protected readonly page: Page) { }
1919
}

‎src/packages/portal/pages/PortalPage/ComparisonPages/ComparePackagesPage/ComparePackagesContent/OperationChangesSummary.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ import { BaseComponent, Content } from '@shared/components/base'
44
export class OperationChangesSummary extends BaseComponent {
55

66
readonly componentType: string = 'changes summary'
7-
readonly breaking = new Content(this.mainLocator.getByTestId('breaking'), `${this.componentName} Breaking Сhanges`)
8-
readonly semiBreaking = new Content(this.mainLocator.getByTestId('semi-breaking'), `${this.componentName} Changes Requiring Attention`)
9-
readonly deprecated = new Content(this.mainLocator.getByTestId('deprecated'), `${this.componentName} Deprecated Сhanges`)
10-
readonly nonBreaking = new Content(this.mainLocator.getByTestId('non-breaking'), `${this.componentName} Non-breaking Сhanges`)
11-
readonly annotation = new Content(this.mainLocator.getByTestId('annotation'), `${this.componentName} Annotation Сhanges`)
12-
readonly unclassified = new Content(this.mainLocator.getByTestId('unclassified'), `${this.componentName} Unclassified Сhanges`)
7+
readonly breaking = new Content(this.mainLocator.getByTestId('breaking'), `${this.componentName} Breaking changes`)
8+
readonly risky = new Content(this.mainLocator.getByTestId('risky'), `${this.componentName} Changes Requiring Attention`)
9+
readonly deprecated = new Content(this.mainLocator.getByTestId('deprecated'), `${this.componentName} Deprecated changes`)
10+
readonly nonBreaking = new Content(this.mainLocator.getByTestId('non-breaking'), `${this.componentName} Non-breaking changes`)
11+
readonly annotation = new Content(this.mainLocator.getByTestId('annotation'), `${this.componentName} Annotation changes`)
12+
readonly unclassified = new Content(this.mainLocator.getByTestId('unclassified'), `${this.componentName} Unclassified changes`)
1313

1414
constructor(rootLocator: Locator, componentName?: string, componentType?: string) {
1515
super(rootLocator, componentName, componentType)

‎src/packages/portal/pages/PortalPage/VersionPage/VersionOverviewTab/OverviewSummaryTab/OverviewSummaryTabBody/OverviewValidationsContent.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ export class OverviewValidationsContent {
77
readonly deprecatedOperations = new Content(this.locator.getByTestId('NumberOfDeprecatedOperationsTypography'), 'Number of deprecated operations')
88
readonly noBwcOperations = new Content(this.locator.getByTestId('NumberOfNoBwcOperationsTypography'), 'Number of no-BWC operations')
99
readonly bwcErrors = new Content(this.locator.getByTestId('NumberOfBwcErrorsTypography'), 'Number of BWC errors')
10-
readonly breakingChanges = new Content(this.locator.getByTestId('breaking'), 'Breaking Сhanges')
11-
readonly semiBreakingChanges = new Content(this.locator.getByTestId('semi-breaking'), 'Changes Requiring Attention')
12-
readonly deprecatedChanges = new Content(this.locator.getByTestId('deprecated'), 'Deprecated Сhanges')
13-
readonly nonBreakingChanges = new Content(this.locator.getByTestId('non-breaking'), 'Non-breaking Сhanges')
14-
readonly annotationChanges = new Content(this.locator.getByTestId('annotation'), 'Annotation Сhanges')
15-
readonly unclassifiedChanges = new Content(this.locator.getByTestId('unclassified'), 'Unclassified Сhanges')
10+
readonly breakingChanges = new Content(this.locator.getByTestId('breaking'), 'Breaking changes')
11+
readonly riskyChanges = new Content(this.locator.getByTestId('risky'), 'Changes Requiring Attention')
12+
readonly deprecatedChanges = new Content(this.locator.getByTestId('deprecated'), 'Deprecated changes')
13+
readonly nonBreakingChanges = new Content(this.locator.getByTestId('non-breaking'), 'Non-breaking changes')
14+
readonly annotationChanges = new Content(this.locator.getByTestId('annotation'), 'Annotation changes')
15+
readonly unclassifiedChanges = new Content(this.locator.getByTestId('unclassified'), 'Unclassified changes')
1616

1717
constructor(private readonly locator: Locator) { }
1818
}

‎src/packages/portal/pages/PortalPage/VersionPage/VersionPackagePage/PackageTabToolbar.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ export class PackageTabToolbar {
77

88
readonly comparedToLnk = new Link(this.page.getByTestId('ComparedToLink'), 'Compared to')
99
readonly sltApiType = new ApiTypeSelect(this.page)
10-
readonly breakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-breaking'), 'Breaking Сhanges filter')
11-
readonly semiBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-semi-breaking'), 'Changes Requiring Attention filter')
12-
readonly deprecatedChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-deprecated'), 'Deprecated Сhanges filter')
13-
readonly nonBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-non-breaking'), 'Non-breaking Сhanges filter')
14-
readonly annotationChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-annotation'), 'Annotation Сhanges filter')
15-
readonly unclassifiedChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-unclassified'), 'Unclassified Сhanges filter')
10+
readonly breakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-breaking'), 'Breaking changes filter')
11+
readonly riskyChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-risky'), 'Changes Requiring Attention filter')
12+
readonly deprecatedChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-deprecated'), 'Deprecated changes filter')
13+
readonly nonBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-non-breaking'), 'Non-breaking changes filter')
14+
readonly annotationChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-annotation'), 'Annotation changes filter')
15+
readonly unclassifiedChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-unclassified'), 'Unclassified changes filter')
1616
readonly searchbar = new SearchBar(this.page.getByTestId('SearchOperations'), 'Operations')
1717
readonly filtersBtn = new Button(this.page.getByTestId('FiltersButton'), 'Filters')
1818
readonly listViewBtn = new Button(this.page.locator('button[value=list]'), 'List View')

‎src/packages/shared/components/custom/table-cells/ChangesTableCell.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ import { Content, TableCell } from '@shared/components/base'
33

44
export class ChangesTableCell extends TableCell {
55

6-
readonly breakingChanges = new Content(this.mainLocator.getByTestId('breaking'), 'Breaking Сhanges')
7-
readonly deprecatedChanges = new Content(this.mainLocator.getByTestId('deprecated'), 'Deprecated Сhanges')
8-
readonly nonBreakingChanges = new Content(this.mainLocator.getByTestId('non-breaking'), 'Non-breaking Сhanges')
9-
readonly semiBreakingChanges = new Content(this.mainLocator.getByTestId('semi-breaking'), 'Changes Requiring Attention')
10-
readonly annotationChanges = new Content(this.mainLocator.getByTestId('annotation'), 'Annotation Сhanges')
11-
readonly unclassifiedChanges = new Content(this.mainLocator.getByTestId('unclassified'), 'Unclassified Сhanges')
6+
readonly breakingChanges = new Content(this.mainLocator.getByTestId('breaking'), 'Breaking changes')
7+
readonly deprecatedChanges = new Content(this.mainLocator.getByTestId('deprecated'), 'Deprecated changes')
8+
readonly nonBreakingChanges = new Content(this.mainLocator.getByTestId('non-breaking'), 'Non-breaking changes')
9+
readonly riskyChanges = new Content(this.mainLocator.getByTestId('risky'), 'Changes Requiring Attention')
10+
readonly annotationChanges = new Content(this.mainLocator.getByTestId('annotation'), 'Annotation changes')
11+
readonly unclassifiedChanges = new Content(this.mainLocator.getByTestId('unclassified'), 'Unclassified changes')
1212

1313
constructor(rootLocator: Locator, componentName?: string, componentType?: string) {
1414
super(rootLocator, componentName, componentType || 'changes cell')

‎src/packages/shared/entities/changes.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
export const BREAKING_CHANGES = 'breaking'
2-
export const SEMI_BREAKING_CHANGES = 'semi-breaking'
2+
export const RISKY_CHANGES = 'risky'
33
export const NON_BREAKING_CHANGES = 'non-breaking'
44
export const ANNOTATION_CHANGES = 'annotation'
55
export const UNCLASSIFIED_CHANGES = 'unclassified'
66

77
export type Changes =
88
typeof BREAKING_CHANGES
9-
| typeof SEMI_BREAKING_CHANGES
9+
| typeof RISKY_CHANGES
1010
| typeof NON_BREAKING_CHANGES
1111
| typeof ANNOTATION_CHANGES
1212
| typeof UNCLASSIFIED_CHANGES
1313

1414
export type ChangeSummary =
1515
typeof BREAKING_CHANGES
16-
| typeof SEMI_BREAKING_CHANGES
16+
| typeof RISKY_CHANGES
1717
| typeof NON_BREAKING_CHANGES
1818
| typeof UNCLASSIFIED_CHANGES

‎src/packages/shared/entities/operation.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ type OperationMetadataTest = {
1616
breaking: {
1717
description: string
1818
}
19-
semiBreaking: {
19+
risky: {
2020
description: string
2121
}
2222
nonBreaking: {

‎src/test-data/portal/operations.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ export const CREATE_LIST_OF_USERS_V1_UPDATED: Operation = {
155155
breaking: {
156156
description: '[Deleted] response \'400\'',
157157
},
158-
semiBreaking: {
158+
risky: {
159159
description: '[Deleted] header \'X-Expires-After\'',
160160
},
161161
nonBreaking: {
@@ -236,7 +236,7 @@ export const DEL_ORDER_V1: Operation = {
236236
method: 'delete',
237237
tags: 'store',
238238
changes: {
239-
semiBreaking: {
239+
risky: {
240240
description: '[Deleted] response \'400\'',
241241
},
242242
},

‎src/test-data/shared/messages.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export const TOOLTIP_SEVERITY_MSG = {
22
breaking: 'Breaking change is a change that breaks backward compatibility with the previous version of API. For example, deleting an operation, adding a required parameter or changing type of a parameter are breaking changes.',
33
nonBreaking: 'Non-breaking change is change that does not break backward compatibility with the previous version of API. For example, adding new operation or optional parameter is non-breaking change.',
4-
semiBreaking: [
4+
risky: [
55
'A change requiring attention is a change that breaks backward compatibility according to the rules:',
66
'operation was annotated as deprecated in at least two previous consecutive releases and then it was deleted',
77
'operation is marked as no-BWC',

‎src/tests/portal/05-view-details/5.2.1-package-details.spec.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ test.describe('5.2.1 Package details', () => {
112112
await expect.soft(overviewTab.summaryTab.body.restApi.noBwcOperations).toHaveText('3')
113113
await expect.soft(overviewTab.summaryTab.body.restApi.bwcErrors).toHaveText('2')
114114
await expect.soft(overviewTab.summaryTab.body.restApi.breakingChanges).toHaveText('2')
115-
await expect.soft(overviewTab.summaryTab.body.restApi.semiBreakingChanges).toHaveText('2')
115+
await expect.soft(overviewTab.summaryTab.body.restApi.riskyChanges).toHaveText('2')
116116
await expect.soft(overviewTab.summaryTab.body.restApi.deprecatedChanges).toHaveText('2')
117117
await expect.soft(overviewTab.summaryTab.body.restApi.nonBreakingChanges).toHaveText('2')
118118
await expect.soft(overviewTab.summaryTab.body.restApi.annotationChanges).toHaveText('1')
@@ -153,7 +153,7 @@ test.describe('5.2.1 Package details', () => {
153153
await expect.soft(overviewTab.summaryTab.body.restApi.noBwcOperations).toHaveText('3')
154154
await expect.soft(overviewTab.summaryTab.body.restApi.bwcErrors).toHaveText('0')
155155
await expect.soft(overviewTab.summaryTab.body.restApi.breakingChanges).toHaveText('0')
156-
await expect.soft(overviewTab.summaryTab.body.restApi.semiBreakingChanges).toHaveText('0')
156+
await expect.soft(overviewTab.summaryTab.body.restApi.riskyChanges).toHaveText('0')
157157
await expect.soft(overviewTab.summaryTab.body.restApi.deprecatedChanges).toHaveText('0')
158158
await expect.soft(overviewTab.summaryTab.body.restApi.nonBreakingChanges).toHaveText('0')
159159
await expect.soft(overviewTab.summaryTab.body.restApi.annotationChanges).toHaveText('0')
@@ -187,7 +187,7 @@ test.describe('5.2.1 Package details', () => {
187187
await portalPage.gotoVersion(V_P_PKG_CHANGELOG_REST_ANNOTUNCLAS_R)
188188

189189
await expect.soft(overviewTab.summaryTab.body.restApi.breakingChanges).toHaveText('0')
190-
await expect.soft(overviewTab.summaryTab.body.restApi.semiBreakingChanges).toHaveText('0')
190+
await expect.soft(overviewTab.summaryTab.body.restApi.riskyChanges).toHaveText('0')
191191
await expect.soft(overviewTab.summaryTab.body.restApi.deprecatedChanges).toHaveText('0')
192192
await expect.soft(overviewTab.summaryTab.body.restApi.nonBreakingChanges).toHaveText('0')
193193
await expect.soft(overviewTab.summaryTab.body.restApi.annotationChanges).toHaveText('1')

0 commit comments

Comments
 (0)