feat: performance optimization for changelog build type
#159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/performance-optimization # Conflicts: # package.json
b41ex
changed the title
changelog build type
makeev-pavel
reviewed
Oct 6, 2025
| init: (lastIdentityProviderId: string | null) => Promise<void> | ||
| } | ||
|
|
||
| async function createCommonResolvers(): Promise<BuilderResolvers> { |
There was a problem hiding this comment.
Don't need async here. All resolvers in this function should also not be async. They are synchronous and return a nested asynchronous function.
makeev-pavel
reviewed
Oct 6, 2025
| }, | ||
| { | ||
| resolvers: builderResolvers, | ||
| resolvers: await createCommonResolvers(), |
There was a problem hiding this comment.
after deleting async from createCommonResolvers, the 'await' should disappear here
makeev-pavel
reviewed
Oct 6, 2025
| } | ||
| } | ||
|
|
||
| export async function versionDocumentsResolver(): Promise<VersionDocumentsResolver> { |
There was a problem hiding this comment.
this is a synchronous function
makeev-pavel
reviewed
Oct 6, 2025
| } | ||
| } | ||
|
|
||
| export async function rawDocumentResolver(): Promise<RawDocumentResolver> { |
There was a problem hiding this comment.
this is a synchronous function
makeev-pavel
reviewed
Oct 6, 2025
| const response = await getPublishedDocumentRawBlob(packageId, version, slug) | ||
|
|
||
| const data = await response.blob() | ||
| const filename = response.headers.get('content-disposition')!.split('filename=')[1].slice(1, -1) |
There was a problem hiding this comment.
is there any need to verify that we were able to get the filename?
…ernal changes and OAS extension changes
… based on new api-processor contract
…ct for prefix groups
… groups comparison, e.g. remove servers
…ring operations in prefix groups due to changes in behavior of isLoading flag in React Query 4
…refix groups in api-processor
…ormance-optimization' into feature/performance-optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.