Fix thread safety and resource leaks in DB class#51
Draft
Copilot wants to merge 4 commits intofix/resolve_vulnerabilitiesfrom
Draft
Fix thread safety and resource leaks in DB class#51Copilot wants to merge 4 commits intofix/resolve_vulnerabilitiesfrom
Copilot wants to merge 4 commits intofix/resolve_vulnerabilitiesfrom
Conversation
Co-authored-by: PhBouzid <15084032+PhBouzid@users.noreply.github.com>
Co-authored-by: PhBouzid <15084032+PhBouzid@users.noreply.github.com>
Co-authored-by: PhBouzid <15084032+PhBouzid@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
This is <pip-setuptools-caller> -- a caller that pip uses to run setup.py- It imports setuptools before invoking setup.py, to enable projects that directlyimport from
|
Copilot
AI
changed the title
[WIP] Fix vulnerabilities in codebase
Fix thread safety and resource leaks in DB class
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on src/db.py: class-level lock causes unnecessary serialization across DB instances, and connections leak when
login=True.Changes
Instance-level locking: Moved
_lockfrom class to instance attribute. Each DB instance now has its own lock, eliminating cross-instance contention when operating on separate database files.Resource leak fix: Connections created with
login=Trueare now properly closed infinallyblocks. Previously, temporary connections were never closed.APSW compatibility: Removed cursor context managers (
with cursor:). APSW cursors don't support the context manager protocol and are lightweight - they don't require explicit cleanup.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.