test: correcting the existing test case so that we will get the alert#59
Open
karthikkesarla wants to merge 1 commit intomainfrom
Open
test: correcting the existing test case so that we will get the alert#59karthikkesarla wants to merge 1 commit intomainfrom
karthikkesarla wants to merge 1 commit intomainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
the below changes are need for this to be successful Netcracker/qubership-docker-integration-tests#3 |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Consul-service robot tests we have alert by name "ConsulIsDownAlarm" to make this alert activated we need the test case "Consul Is Down Alert" as it was failing we modified it and wrote tin below mentioned 2 ways.
Description
What for is that MR?
Consul-service robot tests we have alert by name "ConsulIsDownAlarm" to make this alert activated we need the test case "Consul Is Down Alert" as it was failing we modified it and wrote tin below mentioned 2 ways.
Implementation details
Consul-service robot tests we have alert by name "ConsulIsDownAlarm" to make this alert activated we were deleting all the pods but it was not activating the alert. To make that alert active we need have used 2 approches 'changing memory to very low values' and 'changing the readiness probe unhealty'. In this tests we first capture the existing details and change to make pods unhealty and once alert is activated revert it back to orginal values.
Finally we were asked to use memory approach, keeping that removing the other changes.
Test cases
"Consul Is Down Alert" we had now re-wrote it into 2 ways "Consul Is Down Alert Using Memory Changes" and "Consul Is Down Alert Using Readiness Probe"
Related Tickets & Documents
Related Issue #
Closes #
This also needs this changes to be in place: Netcracker/qubership-docker-integration-tests#3
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Breaking Change checklist
If your PR includes any deployment or processing changes, please utilize this checklist:
Added/updated tests?
have not been included
[optional] Are there any things to highlight or double check?
[optional] What gif best describes this PR or how it makes you feel?