Open
Conversation
asatt
reviewed
Nov 7, 2025
| && usermod -a -G 0 robot \ | ||
| # Install dependencies | ||
| && python3 -m pip install --no-cache-dir --upgrade \ | ||
| && python3 -m pip install --no-cache-dir --upgrade pip==${PIP} \ |
Collaborator
There was a problem hiding this comment.
Just a question, maybe better to set pip==25.3 inside the RUN instruction? In this case, Dependabot can automatically update the version. Not sure that Dependabot can update when a version is specified as an argument.
Plus, I don't see in GitHub Action for build that this new ARG is really used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
TDB
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Breaking Change checklist
If your PR includes any deployment or processing changes, please utilize this checklist:
Added/updated tests?
have not been included
[optional] Are there any things to highlight or double check?
[optional] What gif best describes this PR or how it makes you feel?