Open
Conversation
* feat: Add RegDef V2 validation with version detection Detect version field in RegDef files and validate against V2 schema when version is 2.0. Use logger for validation messages and move schema paths to constants. * feat: Add V2 cloud registry support for artifact searcher - Add AuthConfig model for V2 authentication configuration - Add version and auth_config fields to Registry model - Add V2 routing in check_artifact_async with fallback to V1 - Add CloudAuthHelper for AWS/GCP cloud registry authentication - Add environment credential loading for V2 cloud registries - Add V2 cloud registry dependencies (boto3, google-auth) - Add comprehensive tests for V2 models and routing Preserves all V1 functionality including: - Nexus detection and URL conversion - Snapshot version resolution - URL-based artifact search * fix: V2 artifact searcher cleanup and improvements - Simplified retry logic (2 retries, 5s fixed delay) - Reduced timeouts to reasonable values (60s search, 120s download) - Removed debug/diagnostic code - Removed unnecessary test files - Clean up code style * fix: minor issues on v2 * fix: changes for v2 working with Auth_config as null or empty for Artifacotry/nexus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect version field in RegDef files and validate against V2 schema when version is 2.0. Use logger for validation messages and move schema paths to constants.
Preserves all V1 functionality including:
Simplified retry logic (2 retries, 5s fixed delay)
Reduced timeouts to reasonable values (60s search, 120s download)
Removed debug/diagnostic code
Removed unnecessary test files
Clean up code style
fix: minor issues on v2
fix: changes for v2 working with Auth_config as null or empty for Artifacotry/nexus
Pull Request
Summary
Provide a concise description of what this pull request does and why it is needed.
Issue
Link to the issue(s) this PR addresses (e.g.,
Fixes #123orCloses #456). If no issue exists, explain why this change is necessary.Breaking Change?
If yes, describe the breaking change and its impact (e.g., API changes, behavior changes, or required updates for users).
Scope / Project
Specify the component, module, or project area affected by this change (e.g.,
docs,actions,workflows).Implementation Notes
Provide details on how the change was implemented, including any technical considerations, trade-offs, or notable design decisions. Leave blank if not applicable.
Tests / Evidence
Describe how the changes were verified, including:
Additional Notes
Include any extra information, such as:
Leave blank if not applicable.