Allow @Source resolution for interface types#2199
Closed
reicheltp wants to merge 2 commits intoNetflix:masterfrom
Closed
Allow @Source resolution for interface types#2199reicheltp wants to merge 2 commits intoNetflix:masterfrom
@Source resolution for interface types#2199reicheltp wants to merge 2 commits intoNetflix:masterfrom
Conversation
Author
|
@paulbakker Is there something missing, to get this reviewed? |
90d04a0 to
89c8705
Compare
- Updated `SourceArgumentResolver` to support assigning interface types by using `isAssignableFrom`. - Added test cases for handling `@Source` with interface types. - Extended GraphQL schema and test data to include `Movie` and `Entertainment` examples.
89c8705 to
e288467
Compare
Collaborator
|
Closing this in favor of #2254 which has been released. Apologies for missing this contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
first
Pull Request type
Changes in this PR
Make the
@Sourceattribute more robust by allowing to be bound to an interface / abstract class parameter.SourceArgumentResolverto support assigning interface types by usingisAssignableFrom.@Sourcewith interface types.MovieandEntertainmentexamples.This PR solves the following problem:
Given a schema like this:
Allows us to have a resolver using
DgsDataFetchingEnvironmentlike this:But the implementation with
@Sourcecrashed with error:Invalid source type 'B'. Expected type 'A'. Regardless, that B is assignable to A.Alternatives considered
dfe.getSource()-> boiler code.