Open
Conversation
kilink
requested review from
asibross,
iparadiso,
iuliiasobolevska,
jjacobs44,
kzwang,
paulbakker and
srinivasankavitha
as code owners
kilink
commented
Sep 23, 2025
| price: Float | ||
| } | ||
|
|
||
| scalar Upload |
Member
Author
There was a problem hiding this comment.
This scalar is getting added by the multipart-spring-graphql dependency. With the bug fixed, it caused the schema to fail to parse due to duplicate scalar definitions.
The schemaResources method of DgsGraphQLSourceBuilder did not actually retain the passed in schema resources.
kilink
force-pushed
the
dgs-graphql-source-builder-resource-bug
branch
from
3ad258a to
97de196
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schemaResources method of DgsGraphQLSourceBuilder did not actually retain the passed in schema resources.