Avoid expensive lookup in DefaultDgsDataLoaderProvider#2273
Merged
paulbakker merged 1 commit intomasterfrom Feb 3, 2026
Merged
Avoid expensive lookup in DefaultDgsDataLoaderProvider#2273paulbakker merged 1 commit intomasterfrom
paulbakker merged 1 commit intomasterfrom
Conversation
Avoid calling DataLoaderRegistry#getKeys, as it copies the key set; instead use getDataLoader to check if an existing DataLoader is registered with the supplied name. Additionally, clean up DefaultDgsDataLoaderProvider: - Use Kotlin extensions on ApplicationContext - Remove unnecessary casts
kilink
requested review from
asibross,
iparadiso,
iuliiasobolevska,
jjacobs44,
kzwang,
paulbakker and
srinivasankavitha
as code owners
kilink
force-pushed
the
default-dgs-data-loader-provider
branch
from
b962362 to
029983a
Compare
paulbakker
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid calling DataLoaderRegistry#getKeys, as it copies the key set; instead use getDataLoader to check if an existing DataLoader is registered with the supplied name.
Additionally, clean up DefaultDgsDataLoaderProvider:
An allocation profile from a production app shows that a lot of allocations occur due to this
getKeyscall: