Adjust a few macros for MSVC-compatibility#1411
Merged
nilfm99 merged 2 commits intoNetflix:masterfrom Feb 12, 2025
Merged
Conversation
MSVC doesn't have an equivalent for __attribute__((unused)) on functions.
Under MSVC, '__forceinline' implies 'inline', yielding some warnings when they are used together. In several other codebases I happened to have lying around, a macro similar to FORCE_INLINE always includes the 'inline' keyword, probably for the same reason.
nilfm99
approved these changes
Feb 12, 2025
Collaborator
nilfm99
left a comment
nilfm99
left a comment
There was a problem hiding this comment.
thanks for the contributions!
Contributor
Author
|
@nilfm99 Thank you for reviewing my changes. I have a few more that I need to test more broadly before I submit them, but the result is that I've been able to get it compiling under MSVC again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.