Additional AVX optimizations with build and vmaf accuracy fixes#1452
Merged
kylophone merged 8 commits intoNetflix:masterfrom Mar 20, 2026
Merged
Additional AVX optimizations with build and vmaf accuracy fixes#1452kylophone merged 8 commits intoNetflix:masterfrom
kylophone merged 8 commits intoNetflix:masterfrom
Conversation
Resolve the path for picture.h file while compiling with AVX
optimization patches.
Signed-off-by: Vaibhav Shankar <vaibhav.shankar@intel.com>
…ss identified accuracy discrepancies Signed-off-by: Christopher Bird <christopher.a.bird@intel.com>
This change fixes accuracy mismatches in the AVX-512 implementation of adm_decouple_512. The issue was reproducible only with narrow width video files from Netflix’s Test: - Verified AVX-512 output matches scalar implementation Signed-off-by: Vaibhav Shankar <vaibhav.shankar@intel.com>
Resolves accuracy mismatches in the AVX2 implementation of adm_dwt2_8_avx2. The issue was reproducible only with specific narrow width video files. Test: - Verified AVX2 output(accuracy) matches the scalar implementation Signed-off-by: Vaibhav Shankar <vaibhav.shankar@intel.com>
Update AVX-related code to use data types compatible with both Linux and Windows. Tested on Windows (MSYS2) and Linux: - Build completes successfully - All tests pass Signed-off-by: Vaibhav Shankar <vaibhav.shankar@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces and supersedes PR #1439, which is now stale.
It carries forward the original AVX2/AVX512 work, fixes accuracy issues, and resolves build problems so the AVX paths are ready to land.
Summary
picture.hpath issues seen when building with AVX optimizations enabled.Details
The series includes the following logical changes:
picture.hTesting
On an Intel Xeon test system: (GNR with Ubuntu 24.04)
vmaf_v0.6.1.jsonand checked:Supersedes
Once this is merged, PR #1439 can be closed in favor of this updated, tested series.