fix(ns-ha): send gratuitous ARP for WANs #1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements gratuitous ARP functionality for WAN interfaces in the high availability module. When the system becomes the master node, it sends gratuitous ARP packets to update switch ARP tables for WAN interfaces, which are not automatically tracked by keepalived.
Key changes:
- Adds a new
send_gratuitous_arp()function to handle gratuitous ARP packets for WAN interfaces - Integrates the function call into the main enable sequence
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gsanchietti
force-pushed
the
send_arp
branch
2 times, most recently
from
1e866a9 to
bbef2f1
Compare
gsanchietti
force-pushed
the
send_arp
branch
2 times, most recently
from
09def3b to
ca5447c
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Keepalived automatically send gratuitous ARP for tracked interfaces. Since WAN interfaces are not tracked, gratuitous ARP packets must be sent just after the switch to master.
Changes: - wait for the device to be up, wait maximum 5 seconds per interface - wait for IP to be configured into the device, wait maximum 5 seconds per interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keepalived automatically send gratuitous ARP for tracked interfaces. Since WAN interfaces are not tracked, gratuitous ARP packets must be sent just after the switch to master.