Skip to content

fix(flashstart): reloading firewall instead of restarting #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tbaile merged 1 commit into from
Nov 17, 2025
Merged

fix(flashstart): reloading firewall instead of restarting #1432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/ns-flashstart/files/ns-flashstart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,8 @@ def __save(pending_changes: bool):
if pending_dhcp:
subprocess.run(['ubus', 'call', 'uci', 'commit', json.dumps({'config': 'dhcp'})], check=True)
if pending_firewall:
# reload the firewall if changes are there, this is done cause sets are not reloaded correctly after the
# commit this 100% needs to be fixed upstream.
e_uci.commit('firewall')
subprocess.run(['fw4', 'restart'], capture_output=True)
subprocess.run(['ubus', 'call', 'uci', 'commit', json.dumps({'config': 'firewall'})], check=True)
subprocess.run(['fw4', 'reload-sets'], capture_output=True)


def __add_bypass_ipset():
Expand Down
Loading