fix(ns-api): gracefully handle error when checking for updates#990
Merged
fix(ns-api): gracefully handle error when checking for updates#990
Conversation
Tbaile
changed the title
gsanchietti
requested changes
Jan 7, 2025
Member
gsanchietti
left a comment
gsanchietti
left a comment
There was a problem hiding this comment.
Handlers for python-requests call are ok, but restore missing handler for uci.get
gsanchietti
approved these changes
Jan 7, 2025
Member
gsanchietti
left a comment
gsanchietti
left a comment
There was a problem hiding this comment.
Create an issue for it before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If for any reason the upstream update server goes offline (both community and enterprise repositories), several issues arise while viewing the Updates page.
By adding the
python3-requestspackage it's possible to figure what is going wrong and what happened to the request, leaving the UI with specific error messages that allows to tell the user exactly what is going on.