Skip to content

fix(ns-plug): avoid mwan3 alerts during restart#994

Merged
Tbaile merged 1 commit intomainfrom
mwan3-alert-restart
Jan 29, 2025
Merged

fix(ns-plug): avoid mwan3 alerts during restart#994
Tbaile merged 1 commit intomainfrom
mwan3-alert-restart

Conversation

@filippocarletti
Copy link
Member

@filippocarletti filippocarletti commented Jan 2, 2025

Running /etc/init.d/mwan3 restart produces a rapid disconnect/connect sequence which triggers an alert lasting a few seconds. This PR avoid the false alarm delaying disconnect alerts by 30 seconds.

#992 required.

See #1054

Running /etc/init.d/mwan3 restart produces a rapid disconnect/connect
sequence which triggers an alert lasting a few seconds.
This PR avoid the false alarm delaying disconnect alerts by 30 seconds.

#992 required.
@filippocarletti
Copy link
Member Author

The only issue remaining is the following log:

mwan3-hook: Script /usr/libexec/mwan-hooks/send-mwan-alert failed with exit code 129

Exit code 129 means that the process has been killed with SIGHUP (128 + 1).
We could handle 129 as a special case in /usr/libexec/ns-plug/mwan-hooks

Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really do not like this approach: it feels too hacky

Feel free to merge if your tests were good enough.
Before merge, please open an issue for it

@gsanchietti gsanchietti requested a review from Tbaile January 7, 2025 15:44
@Tbaile
Copy link
Collaborator

Tbaile commented Jan 7, 2025

If this is a disconnection, shouldn't be treated the same as the others? (the IT might want to be notified if at 10:30 AM the VOIP active connections dropped, otherwise this info is lost)

@Tbaile
Copy link
Collaborator

Tbaile commented Jan 13, 2025

Talked /w Giacomo, while we think the change is fine, there's the need to open two PRs for this changes, one for the timeout change and the other for the alert during restart, so the work can be tracked easily (and reverted in even easier manner)

Ping me internally if you want me to do it

@Tbaile Tbaile removed their request for review January 13, 2025 09:09
@Tbaile Tbaile self-assigned this Jan 13, 2025
@Tbaile Tbaile requested a review from gsanchietti January 29, 2025 16:11
@Tbaile Tbaile changed the title ns-plug: avoid mwan3 alerts during restart fix(ns-plug): avoid mwan3 alerts during restart Jan 29, 2025
@Tbaile Tbaile merged commit a551eef into main Jan 29, 2025
1 check passed
@Tbaile Tbaile deleted the mwan3-alert-restart branch January 29, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants