fix(ns-plug): avoid mwan3 alerts during restart#994
Conversation
Running /etc/init.d/mwan3 restart produces a rapid disconnect/connect sequence which triggers an alert lasting a few seconds. This PR avoid the false alarm delaying disconnect alerts by 30 seconds. #992 required.
|
The only issue remaining is the following log: Exit code 129 means that the process has been killed with SIGHUP (128 + 1). |
gsanchietti
left a comment
There was a problem hiding this comment.
I really do not like this approach: it feels too hacky
Feel free to merge if your tests were good enough.
Before merge, please open an issue for it
|
If this is a disconnection, shouldn't be treated the same as the others? (the IT might want to be notified if at 10:30 AM the VOIP active connections dropped, otherwise this info is lost) |
|
Talked /w Giacomo, while we think the change is fine, there's the need to open two PRs for this changes, one for the timeout change and the other for the alert during restart, so the work can be tracked easily (and reverted in even easier manner) Ping me internally if you want me to do it |
Running /etc/init.d/mwan3 restart produces a rapid disconnect/connect sequence which triggers an alert lasting a few seconds. This PR avoid the false alarm delaying disconnect alerts by 30 seconds.
#992 required.
See #1054