Skip to content

refactor(netmap): using procd instead of pre-post commits#999

Merged
Tbaile merged 3 commits intomainfrom
issue-995
Jan 7, 2025
Merged

refactor(netmap): using procd instead of pre-post commits#999
Tbaile merged 3 commits intomainfrom
issue-995

Conversation

@Tbaile
Copy link
Collaborator

@Tbaile Tbaile commented Jan 7, 2025

When updating the image, the content of the folder /usr/share/ gets thrashed, and since the generation of nft rules is triggered only when committing changes, this doesn't get triggered when a new image is installed.
The refactor adds a init.d script that handles changes and starts at boot, which solves the update problem.

Ref

@Tbaile Tbaile requested a review from gsanchietti January 7, 2025 10:55
@Tbaile Tbaile marked this pull request as ready for review January 7, 2025 10:55
@Tbaile Tbaile requested a review from gsanchietti January 7, 2025 15:28
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash before merge

@Tbaile
Copy link
Collaborator Author

Tbaile commented Jan 7, 2025

Squash before merge

Is there another way of merging? 😬

@Tbaile Tbaile merged commit 2c99b60 into main Jan 7, 2025
1 check passed
@Tbaile Tbaile deleted the issue-995 branch January 7, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants