Conversation
4cdc465 to
ad117fd
Compare
…ndling and loading states
…dditional volume handling
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the user interface for application installation, cloning, moving, and restoration by adding offline node detection and volume selection capabilities. The changes convert several modals to wizard-style interfaces and implement comprehensive cluster status checking.
Changes:
- Converted InstallAppModal, CloneOrMoveAppModal, and RestoreSingleInstanceModal from simple modals to multi-step wizards with volume selection
- Added offline node detection and display logic to properly disable nodes that are either non-eligible or offline
- Introduced AdditionnalVolumesSelector component for selecting storage volumes during installation/restoration
- Removed obsolete translation keys that were no longer needed after the UI improvements
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| InstallAppModal.vue | Converted to wizard with volume selection, added offline node detection and cluster status checking |
| CloneOrMoveAppModal.vue | Converted to wizard with volume selection, integrated offline node handling into disabled nodes logic |
| AdditionnalVolumesSelector.vue | New component for displaying and selecting storage volumes with usage information |
| NodeSelector.vue | Added visual indicator for nodes with additional storage available |
| RestoreSingleInstanceModal.vue | Extended with volume selection step and offline node detection for backup restoration |
| translation files | Removed obsolete translation keys and added new keys for volume selection and offline status |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/ui/src/components/software-center/AdditionnalVolumesSelector.vue
Outdated
Show resolved
Hide resolved
core/ui/src/components/software-center/AdditionnalVolumesSelector.vue
Outdated
Show resolved
Hide resolved
…Nodes in multiple modals
…nnalVolumesSelector component
…ing and state management
andre8244
reviewed
Jan 26, 2026
andre8244
reviewed
Jan 26, 2026
core/ui/src/components/software-center/AdditionalVolumesSelector.vue
Outdated
Show resolved
Hide resolved
… fetchNodesList for clarity
…oneOrMoveAppModal and InstallAppModal
…RestoreSingleInstanceModal
andre8244
reviewed
Jan 27, 2026
Contributor
andre8244
left a comment
There was a problem hiding this comment.
Just a few minor adjustments then we're done 💪
andre8244
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves node selection and storage handling across install/restore/clone/move flows.
Changes
Node selection
Additional disk / volume support
list-mountpoints.Modals impacted
Other
@nethserver/ns8-ui-libto1.11.0.Notes for testing or review
the actions list-mountpoints should show your disk
for a good testing
Refs NethServer/dev#7757