feat(api-server): support assigning multiple roles#1061
Merged
DavidePrincipi merged 2 commits intomainfrom Jan 30, 2026
Merged
Conversation
DavidePrincipi
force-pushed
the
bug-7836
branch
from
c6e688a to
6dffd28
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edospadoni
approved these changes
Jan 29, 2026
Authorization of node actions is splitted in three roles: - fwadm - portsadm - tunadm Implement multiple role assignments for a single agent. With this new feature, a module like nethvoice-proxy can be granted both fwadm and portsadm role on the same node, eliminating the hack that define fake role names like "fwadm,portsadm". The comma in role names is now considered a split point by api-server to authorize the requested action.
Split role assignments on comma to grant a module multiple roles on the same target. For example a nethvoice-proxy application can be granted both fwadm and portsadm on node/1. The resulting list of authorized actions will be the union of all granted roles.
DavidePrincipi
force-pushed
the
bug-7836
branch
from
6dffd28 to
c0985e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split role assignments on comma to grant a module multiple roles on the same target. For example a nethvoice-proxy application can be granted both fwadm and portsadm on node/1.
The resulting list of authorized actions will be the union of all granted roles.
Refs NethServer/dev#7836