Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates task handling in several modals to use per-task eventIds so that progress, completion, and error events can be uniquely correlated with the task instance that triggered them, improving traceability across the task lifecycle.
Changes:
- Updated
InstallAppModaltask flows (get-cluster-status,list-nodes,list-mountpoints,add-module) to generate a UUIDeventId, subscribe to${action}-*-<eventId>events, and passeventIdthroughextrawhen creating tasks. - Updated
CloneOrMoveAppModalfor the same pattern onlist-nodes,get-cluster-status,list-mountpoints, andclone-module, and slightly refactored mount-points completion handling for cleaner state updates. - Updated
RestoreSingleInstanceModalto useeventIdforlist-modules,list-nodes,list-mountpoints,restore-module,determine-restore-eligibility, andget-cluster-status, aligning these flows with the notification mixin’seventId-aware event naming.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
core/ui/src/components/software-center/InstallAppModal.vue |
Switches cluster and node task handling to eventId-scoped event names and passes eventId in task extra, plus a small refactor of mount-point result assignment. |
core/ui/src/components/software-center/CloneOrMoveAppModal.vue |
Applies eventId-based event names and propagation for list/get/mountpoint tasks and the clone/move operation, with a minor cleanup of how additional volumes are built. |
core/ui/src/components/backup/RestoreSingleInstanceModal.vue |
Adopts eventId handling for module listing, node listing, mount-point listing, restore, eligibility checks, and cluster status, ensuring consistency with the notification mixin’s event naming and usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andre8244
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance task registration and completion tracking by adding eventId to the InstallAppModal, RestoreSingleInstanceModal, and CloneOrMoveAppModal components. This change improves the ability to trace tasks throughout their lifecycle.
NethServer/dev#7757