Skip to content

Add eventId for task tracking in modals#1070

Merged
stephdl merged 3 commits intomainfrom
sdl-additionalVolumes-eventId
Feb 5, 2026
Merged

Add eventId for task tracking in modals#1070
stephdl merged 3 commits intomainfrom
sdl-additionalVolumes-eventId

Conversation

@stephdl
Copy link
Contributor

@stephdl stephdl commented Feb 4, 2026

Enhance task registration and completion tracking by adding eventId to the InstallAppModal, RestoreSingleInstanceModal, and CloneOrMoveAppModal components. This change improves the ability to trace tasks throughout their lifecycle.

NethServer/dev#7757

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates task handling in several modals to use per-task eventIds so that progress, completion, and error events can be uniquely correlated with the task instance that triggered them, improving traceability across the task lifecycle.

Changes:

  • Updated InstallAppModal task flows (get-cluster-status, list-nodes, list-mountpoints, add-module) to generate a UUID eventId, subscribe to ${action}-*-<eventId> events, and pass eventId through extra when creating tasks.
  • Updated CloneOrMoveAppModal for the same pattern on list-nodes, get-cluster-status, list-mountpoints, and clone-module, and slightly refactored mount-points completion handling for cleaner state updates.
  • Updated RestoreSingleInstanceModal to use eventId for list-modules, list-nodes, list-mountpoints, restore-module, determine-restore-eligibility, and get-cluster-status, aligning these flows with the notification mixin’s eventId-aware event naming.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
core/ui/src/components/software-center/InstallAppModal.vue Switches cluster and node task handling to eventId-scoped event names and passes eventId in task extra, plus a small refactor of mount-point result assignment.
core/ui/src/components/software-center/CloneOrMoveAppModal.vue Applies eventId-based event names and propagation for list/get/mountpoint tasks and the clone/move operation, with a minor cleanup of how additional volumes are built.
core/ui/src/components/backup/RestoreSingleInstanceModal.vue Adopts eventId handling for module listing, node listing, mount-point listing, restore, eligibility checks, and cluster status, ensuring consistency with the notification mixin’s event naming and usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stephdl stephdl requested a review from andre8244 February 5, 2026 09:30
@stephdl stephdl merged commit d87b43b into main Feb 5, 2026
8 checks passed
@stephdl stephdl deleted the sdl-additionalVolumes-eventId branch February 5, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants