Skip to content

Fix NaN handling in mssfix and tun_mtu validation #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gsanchietti merged 10 commits into from
Nov 24, 2025
Merged

Fix NaN handling in mssfix and tun_mtu validation #139

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
45bb5cb
Initial plan
Copilot Nov 24, 2025
091dd74
fix(ui): Add NaN validation for mssfix and tun_mtu inputs
Copilot Nov 24, 2025
44072aa
refactor: Store parsed values to avoid redundant parsing
Copilot Nov 24, 2025
2d2821f
fix: Add radix parameter to parseInt calls
Copilot Nov 24, 2025
0489da4
fix(ui): Add missing error messages for tun_mtu and mssfix validation
Copilot Nov 24, 2025
e136a9b
fix: Add radix parameter to all parseInt calls for consistency
Copilot Nov 24, 2025
c363db0
Apply suggestion from @gsanchietti
gsanchietti Nov 24, 2025
9ece5ba
Apply suggestion from @gsanchietti
gsanchietti Nov 24, 2025
ccca9a3
Apply suggestion from @gsanchietti
gsanchietti Nov 24, 2025
facbf7b
Apply suggestion from @gsanchietti
gsanchietti Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ui/public/i18n/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@
"loki_retention_min": "Logs retention must be greater than 1 day",
"invalid_network": "Invalid network, it mus be a class C network like 192.168.200.0",
"invalid_netmask": "Invalid netmask, it must be a valid netmask like 255.255.255.0",
"invalid_allowed_ips": "Invalid allowed IPs, each entry must be a and IP or CIDR network."
"invalid_allowed_ips": "Invalid allowed IPs, each entry must be a and IP or CIDR network.",
"tun_mtu_min": "TUN MTU must be at least 576",
"mssfix_min": "MSS Fix must be at least 0"
}
}
4 changes: 3 additions & 1 deletion ui/public/i18n/es/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
"404": "Recurso no encontrado",
"invalid_user": "Nombre de usuario no válido: debe contener sólo letras y números",
"network_error": "Error de red",
"validation_error": "Error de validación"
"validation_error": "Error de validación",
"tun_mtu_min": "TUN MTU debe ser al menos 576",
"mssfix_min": "MSS Fix debe ser al menos 0"
},
"settings": {
"user": "Usuario administrador",
Expand Down
4 changes: 3 additions & 1 deletion ui/public/i18n/it/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
"403": "Operazione non autorizzata",
"invalid_cn": "Nome controller non valido: deve contenere solo lettere e numeri",
"invalid_user": "Nome utente non valido: deve contenere solo lettere e numeri",
"invalid_host": "Nome host non valido: deve essere un FQDN valido"
"invalid_host": "Nome host non valido: deve essere un FQDN valido",
"tun_mtu_min": "TUN MTU deve essere almeno 576",
"mssfix_min": "MSS Fix deve essere almeno 0"
},
"settings": {
"title": "Impostazioni",
Expand Down
14 changes: 8 additions & 6 deletions ui/src/views/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,14 +589,16 @@ export default {
}

// validate tun_mtu: minimum 576
if (parseInt(this.tun_mtu) < 576) {
const tunMtuValue = parseInt(this.tun_mtu, 10);
if (isNaN(tunMtuValue) || tunMtuValue < 576) {
this.error.tun_mtu = this.$t("error.tun_mtu_min");
this.focusElement("tun_mtu");
isValidationOk = false;
}

// validate mssfix: minimum 0
if (parseInt(this.mssfix) < 0) {
const mssfixValue = parseInt(this.mssfix, 10);
if (isNaN(mssfixValue) || mssfixValue < 0) {
this.error.mssfix = this.$t("error.mssfix_min");
this.focusElement("mssfix");
isValidationOk = false;
Expand Down Expand Up @@ -699,11 +701,11 @@ export default {
ovpn_netmask: this.netmask,
ovpn_cn: this.cn,
api_user: this.user,
loki_retention: parseInt(this.loki_retention),
prometheus_retention: parseInt(this.prometheus_retention),
loki_retention: parseInt(this.loki_retention, 180),
prometheus_retention: parseInt(this.prometheus_retention, 10),
maxmind_license: this.maxmind_license,
tun_mtu: parseInt(this.tun_mtu),
mssfix: parseInt(this.mssfix),
tun_mtu: parseInt(this.tun_mtu, 1500),
mssfix: parseInt(this.mssfix, 1455),
allowed_ips: this.allowed_ips
.split("\n")
.map((ip) => ip.trim())
Expand Down
Loading