Skip to content

Conversation

@mskrzypkows
Copy link
Collaborator

No description provided.

@mskrzypkows mskrzypkows enabled auto-merge (squash) December 3, 2025 16:11
Copy link
Collaborator

@mikhailUshakoff mikhailUshakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the Taiko coder has an issue.
It’s not possible to encode data larger than one blob in size:
#756

@mskrzypkows
Copy link
Collaborator Author

Updated taiko with improved blob coder, now the test pass.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates from an internal blob encoding implementation to using Taiko's external BlobCoder from the taiko_protocol crate. The changes modernize the blob encoding approach by leveraging alloy's built-in KZG support and Taiko's standardized blob encoding implementation.

Key changes:

  • Replace internal blob encoding with SidecarBuilder<BlobCoder> from taiko_protocol
  • Remove c-kzg dependency in favor of alloy's kzg feature
  • Update taiko-mono dependencies to revision 4a495188afbdbddf41457d440762b89023b32d84

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Bumped version to 1.23.25, removed c-kzg dependency, enabled alloy kzg feature, updated taiko-mono to new revision
Cargo.lock Updated dependency versions and checksums reflecting the dependency changes
common/Cargo.toml Removed c-kzg, added taiko_protocol dependency, added arbitrary feature to alloy in dev-dependencies
common/src/blob/mod.rs Removed build_blob_sidecar function and blob_coder module, updated tests to use SidecarBuilder
common/src/blob/blob_coder.rs Deleted entire file containing internal BlobCoder implementation
common/src/blob/blob_parser.rs Updated test to use SidecarBuilder pattern
common/src/crypto/mod.rs Removed kzg module reference
common/src/crypto/kzg.rs Deleted entire file containing internal KZG helper functions
common/src/l1/blob_indexer.rs Updated test to use BlobTransactionSidecar for versioned hash computation
pacaya/Cargo.toml Removed c-kzg dependency, added taiko_protocol dependency
pacaya/src/l1/propose_batch_builder.rs Updated blob encoding to use SidecarBuilder
shasta/Cargo.toml Removed c-kzg dependency
shasta/src/l1/proposal_tx_builder.rs Imported BlobCoder, updated blob encoding to use SidecarBuilder

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mskrzypkows mskrzypkows merged commit 5413b1e into master Dec 10, 2025
13 checks passed
@mskrzypkows mskrzypkows deleted the taiko_blob_coder branch December 10, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants