-
Notifications
You must be signed in to change notification settings - Fork 11
taiko blob coder #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taiko blob coder #755
Conversation
mikhailUshakoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the Taiko coder has an issue.
It’s not possible to encode data larger than one blob in size:
#756
|
Updated taiko with improved blob coder, now the test pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates from an internal blob encoding implementation to using Taiko's external BlobCoder from the taiko_protocol crate. The changes modernize the blob encoding approach by leveraging alloy's built-in KZG support and Taiko's standardized blob encoding implementation.
Key changes:
- Replace internal blob encoding with
SidecarBuilder<BlobCoder>fromtaiko_protocol - Remove
c-kzgdependency in favor of alloy'skzgfeature - Update taiko-mono dependencies to revision
4a495188afbdbddf41457d440762b89023b32d84
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumped version to 1.23.25, removed c-kzg dependency, enabled alloy kzg feature, updated taiko-mono to new revision |
| Cargo.lock | Updated dependency versions and checksums reflecting the dependency changes |
| common/Cargo.toml | Removed c-kzg, added taiko_protocol dependency, added arbitrary feature to alloy in dev-dependencies |
| common/src/blob/mod.rs | Removed build_blob_sidecar function and blob_coder module, updated tests to use SidecarBuilder |
| common/src/blob/blob_coder.rs | Deleted entire file containing internal BlobCoder implementation |
| common/src/blob/blob_parser.rs | Updated test to use SidecarBuilder pattern |
| common/src/crypto/mod.rs | Removed kzg module reference |
| common/src/crypto/kzg.rs | Deleted entire file containing internal KZG helper functions |
| common/src/l1/blob_indexer.rs | Updated test to use BlobTransactionSidecar for versioned hash computation |
| pacaya/Cargo.toml | Removed c-kzg dependency, added taiko_protocol dependency |
| pacaya/src/l1/propose_batch_builder.rs | Updated blob encoding to use SidecarBuilder |
| shasta/Cargo.toml | Removed c-kzg dependency |
| shasta/src/l1/proposal_tx_builder.rs | Imported BlobCoder, updated blob encoding to use SidecarBuilder |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.