feat: integrate publish preconf fn to permissionless node#873
Merged
mskrzypkows merged 4 commits intoNethermindEth:masterfrom Feb 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates preconfirmation publishing functionality into the permissionless node by enabling it to construct L2 block payloads and submit preconfirmation commitments to the preconfirmation driver.
Changes:
- Added
get_secret_key()method to Signer for extracting secp256k1 private keys needed for commitment signing - Implemented L2BlockV2Payload construction in
main_block_preconfirmation_stepusing slot info and anchor block data - Integrated
post_preconf_requestscall to publish both transaction lists and signed commitments to the preconfirmation driver
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| common/src/signer/mod.rs | Added get_secret_key() method to extract secp256k1::SecretKey from PrivateKey signer variant |
| common/Cargo.toml | Added secp256k1 dependency required for commitment signing |
| Cargo.lock | Updated with secp256k1 dependency |
| permissionless/src/node/config.rs | Added coinbase and l1_height_lag fields to NodeConfig for L2 payload construction |
| permissionless/src/lib.rs | Initialized new NodeConfig fields with preconfer address and l1_height_lag |
| permissionless/src/node/operator/mod.rs | Added getter method preconfirmation_driver() to access the driver for posting requests |
| permissionless/src/node/mod.rs | Implemented preconfirmation publishing logic in main_block_preconfirmation_step |
| permissionless/src/l2/preconfirmation_driver.rs | Changed rpc_client visibility to public and removed dead_code annotation from post_preconf_requests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mskrzypkows
reviewed
Feb 23, 2026
mskrzypkows
reviewed
Feb 23, 2026
mskrzypkows
requested changes
Feb 23, 2026
mskrzypkows
reviewed
Feb 23, 2026
mskrzypkows
approved these changes
Feb 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_secret_key()to Signer for commitment signingL2BlockV2Payloadfrom slot info and anchor blockpost_preconf_requestsfrompreconfirmation_drivetinmain_block_preconfirmation_stepfnpreconfirmation_driverfunction to Operator as it is one of the fields in Node, to use while calling thePreconfirmationDriver