Skip to content

feat(rpcv10): add support for proof_facts in subscription tags for starknet_subscribeNewTransactions#3390

Open
MaksymMalicki wants to merge 7 commits intomaksym/rpcv10-response-flagsfrom
maksym/rpcv10-subscription-tags
Open

feat(rpcv10): add support for proof_facts in subscription tags for starknet_subscribeNewTransactions#3390
MaksymMalicki wants to merge 7 commits intomaksym/rpcv10-response-flagsfrom
maksym/rpcv10-subscription-tags

Conversation

@MaksymMalicki
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.43%. Comparing base (86aa24c) to head (ce39ca6).

Files with missing lines Patch % Lines
rpc/v10/response_flags.go 0.00% 12 Missing ⚠️
rpc/v10/subscriptions.go 64.70% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (40.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           maksym/rpcv10-response-flags    #3390      +/-   ##
================================================================
- Coverage                         74.57%   74.43%   -0.15%     
================================================================
  Files                               378      378              
  Lines                             35546    35597      +51     
================================================================
- Hits                              26508    26495      -13     
- Misses                             6920     6965      +45     
- Partials                           2118     2137      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaksymMalicki MaksymMalicki force-pushed the maksym/rpcv10-response-flags branch 2 times, most recently from c0b55b8 to 9b8cc56 Compare February 6, 2026 10:38
@MaksymMalicki MaksymMalicki force-pushed the maksym/rpcv10-response-flags branch 2 times, most recently from 80afe41 to 8c1afb1 Compare February 13, 2026 13:59
@MaksymMalicki MaksymMalicki force-pushed the maksym/rpcv10-subscription-tags branch from f90a7c1 to 0246be7 Compare February 13, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants